Bold italics adjacent to italics parsed incorrectly

[PaulKleinschmidt]

Subject of the issue

This is an issue I came across while using react-markdown. I have an issue opened in that repo (remarkjs/react-markdown#383) but was asked to report it here as well! Let me know if you need some more details, I'd be happy to add any more info.

using react-markdown,

***bold-italic** italic*

should render as:

bold-italic italic

but instead it renders as:

*bold-italic italic*

Your environment

• OS: macOS Mojave
• Packages: react-markdown": "^4.2.2"
• Env: node@v11.15.0

Steps to reproduce

Paste the markdown noted above (***bold-italic** italic*) into this react-markdown demo environment https://rexxars.github.io/react-markdown/

[ChristianMurphy]

@wooorm I requested this be upstreamed because it appears to be a case where remark in commonmark mode, diverges from commonmark.

https://astexplorer.net/#/gist/c7e7203e08ddc2bd3a9bd8f55562f09b/473a77245b30bb3dd423087c1bd2fddc12ec9c01
vs https://spec.commonmark.org/dingus/?text=***bold-italic**%20italic*

this is likely related to #306 specifically example-389

[wooorm]

Yup, that’s a bug here!

[PaulKleinschmidt]

@wooorm would this be a good first issue? I'd love to attempt to fix this but I'm not very familiar with the codebase.

[wooorm]

Hi Paul! thanks for offering to help!

Emphasis vs. strong is a rather complex topic. About 1/4th of the CommonMark tests (the markdown spec) are about emphasis/strong. I didn’t investigate this problem particularly well, but it seems to definitely not be beginner friendly.

I’m also again actively working on replacing the internals of remark (#439, and happy to say all emphasis tests pass), so any changes to the current code would be overwritten there.

If you’re looking for good first issues in the unified collective to work on though, see this link to a GitHub search.

[wooorm]

Heya, just wanted to give an update about micromark, it’s sort-of a new motor that we’ll soon use in remark to parse markdown. It’s not yet 100% ready but will be relatively soon. The good news is, it fixes this issue! (P.S. see this twitter thread for some more info!)