shouldRevalidate does not stop the loader from revalidating

[aland-x]

I'm using React Router as a...

framework

Reproduction

Getting started template modified to add another route and a link for testing purposes with ssr disabled.

https://github.com/aland-x/should-revalidate-test

https://stackblitz.com/github/aland-x/should-revalidate-test

System Info

Not relevant

Used Package Manager

npm

Expected Behavior

When navigating to /test from the link the loader should not revalidate because the shouldRevalidate export is false.

Actual Behavior

When navigating to /test the loader revalidates.

[timdorr]

shouldRevalidate doesn't prevent the initial loader call. It's used when the loader might be invalidated after an action call. Hence it takes actionResult as one of its params.

[aland-x]

I'm not talking about the initial load I know that part is not prevented by shouldRevalidate. Also this is an app that was built using remix-spa and I tried to migrate it to rrv7 but noticed this bug.

[aland-x]

In the remix version if I set v3_singleFetch to true is has the same behavior as RRv7 now. (shouldRevalidate not work no matter what evne if you pass false)

I'm assuming even when ssr is set to false singeFetch still causes shouldRevalidate to be ignored.