Skip to content

Commit bf44020

Browse files
authored
fix(remix-dev): require.resolve isolateChunks for pnpm (#5637)
Signed-off-by: Logan McAnsh <logan@mcan.sh>
1 parent 4a5a680 commit bf44020

3 files changed

Lines changed: 17 additions & 8 deletions

File tree

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
"remix": patch
3+
"@remix-run/dev": patch
4+
---
5+
6+
resolves an issue when resolving react-refresh for pnpm users

‎packages/remix-dev/compiler/compileBrowser.ts‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -134,13 +134,13 @@ const createEsbuildConfig = (
134134
if (mode === "development" && config.future.unstable_dev) {
135135
// TODO prebundle deps instead of chunking just these ones
136136
let isolateChunks = [
137-
"react",
138-
"react/jsx-dev-runtime",
139-
"react/jsx-runtime",
140-
"react-dom",
141-
"react-dom/client",
142-
"react-refresh/runtime",
143-
"@remix-run/react",
137+
require.resolve("react"),
138+
require.resolve("react/jsx-dev-runtime"),
139+
require.resolve("react/jsx-runtime"),
140+
require.resolve("react-dom"),
141+
require.resolve("react-dom/client"),
142+
require.resolve("react-refresh/runtime"),
143+
require.resolve("@remix-run/react"),
144144
"remix:hmr",
145145
];
146146
entryPoints = {

‎packages/remix-dev/compiler/plugins/hmrPlugin.ts‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,11 @@ export let hmrPlugin = ({
1919
};
2020
});
2121
build.onLoad({ filter: /.*/, namespace: "hmr-runtime" }, () => {
22+
let reactRefreshRuntime = require
23+
.resolve("react-refresh/runtime")
24+
.replace(/\\/g, "/");
2225
let contents = `
23-
import RefreshRuntime from "react-refresh/runtime";
26+
import RefreshRuntime from "${reactRefreshRuntime}";
2427
2528
declare global {
2629
interface Window {

0 commit comments

Comments
 (0)