Skip to content

Commit e9d1bd4

Browse files
committed
test(dev,react): update tests for improved networking
1 parent 3af3eca commit e9d1bd4

2 files changed

Lines changed: 3 additions & 5 deletions

File tree

‎packages/remix-dev/__tests__/cli-test.ts‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,8 +118,6 @@ describe("remix CLI", () => {
118118
119119
[v2_dev]
120120
--command, -c Command used to run your app server
121-
--scheme Scheme for the dev server. Default: http
122-
--host Host for the dev server. Default: localhost
123121
--port Port for the dev server. Default: any open port
124122
--no-restart Do not restart the app server when rebuilds occur.
125123
--tls-key Path to TLS key (key.pem)

‎packages/remix-react/__tests__/components-test.tsx‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,22 +47,22 @@ describe("<LiveReload />", () => {
4747
LiveReload = require("../components").LiveReload;
4848
let { container } = render(<LiveReload />);
4949
expect(container.querySelector("script")).toHaveTextContent(
50-
"let port = undefined || (window.__remixContext && window.__remixContext.dev && window.__remixContext.dev.port) || 8002;"
50+
"url.port = undefined || REMIX_DEV_ORIGIN ? new URL(REMIX_DEV_ORIGIN).port : Number(undefined) || 8002;"
5151
);
5252
});
5353

5454
it("can set the port explicitly", () => {
5555
let { container } = render(<LiveReload port={4321} />);
5656
expect(container.querySelector("script")).toHaveTextContent(
57-
"let port = 4321 || (window.__remixContext && window.__remixContext.dev && window.__remixContext.dev.port) || 8002;"
57+
"url.port = 4321 || REMIX_DEV_ORIGIN ? new URL(REMIX_DEV_ORIGIN).port : Number(undefined) || 8002;"
5858
);
5959
});
6060

6161
it("determines the right port based on REMIX_DEV_SERVER_WS_PORT env variable", () => {
6262
process.env.REMIX_DEV_SERVER_WS_PORT = "1234";
6363
let { container } = render(<LiveReload />);
6464
expect(container.querySelector("script")).toHaveTextContent(
65-
"let port = undefined || (window.__remixContext && window.__remixContext.dev && window.__remixContext.dev.port) || 1234;"
65+
"url.port = undefined || REMIX_DEV_ORIGIN ? new URL(REMIX_DEV_ORIGIN).port : Number(1234) || 8002;"
6666
);
6767
});
6868

0 commit comments

Comments
 (0)