fix: Quote zero-length strings in arguments (#1551)

forivall · remy · commit 2973afbd26e2 · 2019-05-01T08:04:25.000+01:00
If a zero-length string is passed, it does not get properly quoted, and then it is not properly passed to the child process
diff --git a/lib/utils/index.js b/lib/utils/index.js
@@ -69,7 +69,7 @@ var utils = (module.exports = {
       args.map(function (arg) {
         // if an argument contains a space, we want to show it with quotes
         // around it to indicate that it is a single argument
-        if (arg.indexOf(' ') === -1) {
+        if (arg.length > 0 && arg.indexOf(' ') === -1) {
           return arg;
         }
         // this should correctly escape nested quotes

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ var utils = (module.exports = {`
`69`	`69`	`args.map(function (arg) {`
`70`	`70`	`// if an argument contains a space, we want to show it with quotes`
`71`	`71`	`// around it to indicate that it is a single argument`
`72`		`- if (arg.indexOf(' ') === -1) {`
	`72`	`+ if (arg.length > 0 && arg.indexOf(' ') === -1) {`
`73`	`73`	`return arg;`
`74`	`74`	`}`
`75`	`75`	`// this should correctly escape nested quotes`