Skip to content

Improve server stop_event logic #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tovrstra opened this issue Jun 22, 2024 · 1 comment
Closed

Improve server stop_event logic #14

tovrstra opened this issue Jun 22, 2024 · 1 comment

Comments

@tovrstra
Copy link
Contributor

The current solution in #13 is a bit hacky but needed because a bugfix in Python 3.12 is not backported to 3.11 (and older), see python/cpython#120866

A possibly cleaner solution is to postpone setting the stop_event until the end of the handler function.
@tovrstra tovrstra mentioned this issue Jun 22, 2024
Merged
@tovrstra
Copy link
Contributor Author

tovrstra commented Jul 4, 2024

Fixed in #15

@tovrstra tovrstra closed this as completed Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tovrstra