Skip to content

How to use aria-current? #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hellpirat opened this issue Aug 31, 2021 · 3 comments
Closed

How to use aria-current? #28

hellpirat opened this issue Aug 31, 2021 · 3 comments
Labels
html attribute change Bunching these together because there are larger changes that will override. Will revisit after.

Comments

@hellpirat
Copy link

Why this prop is under comment - https://github.com/rescript-lang/rescript-react/blob/master/src/ReactDOM.res#L1091 ?

 <li className="px-4 text-gray-700" ariaCurrent="page"> {"Blog"->React.string} </li>

This argument cannot be applied with label ~ariaCurrent
@ryyppy
Copy link
Member

ryyppy commented Sep 14, 2021

Back then there was no way to seamlessly map this from ReScript to JavaScript. Now with poly-variants mapping to strings, it should be possible to map these attributes.

@rickyvetter rickyvetter added the html attribute change Bunching these together because there are larger changes that will override. Will revisit after. label Jan 22, 2022
@cknitt
Copy link
Member

cknitt commented Oct 1, 2022

See also rescript-lang/rescript#5708.

@cknitt
Copy link
Member

cknitt commented Oct 7, 2022

Done in rescript-lang/rescript#5723.

@cknitt cknitt closed this as completed Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
html attribute change Bunching these together because there are larger changes that will override. Will revisit after.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@cknitt @ryyppy @rickyvetter @hellpirat