Skip to content

Commit e5361b1

Browse files
authored
Revert "Fix issue where exhaustiveness check for pattern matching char was no… (#5744)"
This reverts commit a8b0cfb.
1 parent a8b0cfb commit e5361b1

File tree

5 files changed

+0
-24
lines changed

5 files changed

+0
-24
lines changed

CHANGELOG.md

-4
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,6 @@
1212
1313
# 10.1.0-rc.3
1414

15-
#### :bug: Bug Fix
16-
17-
- Fix issue where exhaustiveness check for pattern matching char was not working https://github.com/rescript-lang/rescript-compiler/issues/5557
18-
1915
# 10.1.0-rc.2
2016

2117
#### :bug: Bug Fix

jscomp/ml/typecore.ml

-5
Original file line numberDiff line numberDiff line change
@@ -1350,11 +1350,6 @@ let partial_pred ~lev ?mode ?explode env expected_ty constrs labels p =
13501350
let state = save_state env in
13511351
try
13521352
reset_pattern None true;
1353-
let expected_ty = match p.ppat_desc, expected_ty.desc with
1354-
| Ppat_constant (Pconst_integer _ ), Tconstr (path, [], _) when Path.same path Predef.path_char ->
1355-
(* Constants such as 'x' are represented as Pconst_integer but expected to have type char *)
1356-
Predef.type_int
1357-
| _ -> expected_ty in
13581353
let typed_p =
13591354
Ctype.with_passive_variants
13601355
(type_pat ~allow_existentials:true ~lev

lib/4.06.1/unstable/js_compiler.ml

-5
Original file line numberDiff line numberDiff line change
@@ -40301,11 +40301,6 @@ let partial_pred ~lev ?mode ?explode env expected_ty constrs labels p =
4030140301
let state = save_state env in
4030240302
try
4030340303
reset_pattern None true;
40304-
let expected_ty = match p.ppat_desc, expected_ty.desc with
40305-
| Ppat_constant (Pconst_integer _ ), Tconstr (path, [], _) when Path.same path Predef.path_char ->
40306-
(* Constants such as 'x' are represented as Pconst_integer but expected to have type char *)
40307-
Predef.type_int
40308-
| _ -> expected_ty in
4030940304
let typed_p =
4031040305
Ctype.with_passive_variants
4031140306
(type_pat ~allow_existentials:true ~lev

lib/4.06.1/unstable/js_playground_compiler.ml

-5
Original file line numberDiff line numberDiff line change
@@ -40301,11 +40301,6 @@ let partial_pred ~lev ?mode ?explode env expected_ty constrs labels p =
4030140301
let state = save_state env in
4030240302
try
4030340303
reset_pattern None true;
40304-
let expected_ty = match p.ppat_desc, expected_ty.desc with
40305-
| Ppat_constant (Pconst_integer _ ), Tconstr (path, [], _) when Path.same path Predef.path_char ->
40306-
(* Constants such as 'x' are represented as Pconst_integer but expected to have type char *)
40307-
Predef.type_int
40308-
| _ -> expected_ty in
4030940304
let typed_p =
4031040305
Ctype.with_passive_variants
4031140306
(type_pat ~allow_existentials:true ~lev

lib/4.06.1/whole_compiler.ml

-5
Original file line numberDiff line numberDiff line change
@@ -216688,11 +216688,6 @@ let partial_pred ~lev ?mode ?explode env expected_ty constrs labels p =
216688216688
let state = save_state env in
216689216689
try
216690216690
reset_pattern None true;
216691-
let expected_ty = match p.ppat_desc, expected_ty.desc with
216692-
| Ppat_constant (Pconst_integer _ ), Tconstr (path, [], _) when Path.same path Predef.path_char ->
216693-
(* Constants such as 'x' are represented as Pconst_integer but expected to have type char *)
216694-
Predef.type_int
216695-
| _ -> expected_ty in
216696216691
let typed_p =
216697216692
Ctype.with_passive_variants
216698216693
(type_pat ~allow_existentials:true ~lev

0 commit comments

Comments
 (0)