Improve Safe Promises with ideas from rescript-promise #5719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

cristianoc opened this issue Oct 3, 2022 · 1 comment

Milestone

Collaborator

cristianoc commented Oct 3, 2022

Safe promises are introduced here: #5709
The PR changes as little as possible, just covers the safety aspect.

There are other, orthogonal improvements, performed here:
https://github.com/ryyppy/rescript-promise
these should be integrated as well.

There are a few open questions:

Should https://github.com/ryyppy/rescript-promise also be made safe?
Also, the docs of https://github.com/ryyppy/rescript-promise are written with the idea that direct promise access would be the main mechanism. With async/await we just don't know what the main mechanism will be.

cristianoc added this to the v10.1 milestone

cristianoc mentioned this issue

Safe promises #5709

Merged

Collaborator Author

cristianoc commented Nov 3, 2022

This goes elsewhere.

cristianoc closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment