Skip to content

[[email protected]] No working prebuilt ReScript compiler #5834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DZakh opened this issue Nov 21, 2022 · 14 comments · Fixed by #5871
Closed

[[email protected]] No working prebuilt ReScript compiler #5834

DZakh opened this issue Nov 21, 2022 · 14 comments · Fixed by #5871

Comments

@DZakh
Copy link
Member

DZakh commented Nov 21, 2022

I've updated rescript to the 10.1.0-rc.5 because of the issue #5638. And it works well, but the CI build took much longer. It can't find the prebuild ReScript compiler and starts building it in CI with other missing dependencies.

It's the only blocker with starting using 10.1.0-rc.5 at Carla right now. Can I help with fixing the issue somehow?

Screen Shot 2022-11-21 at 13 54 45

@DZakh
Copy link
Member Author

DZakh commented Nov 21, 2022

Hail the cache, it works well when it hits. But still would be nice to have a prebuilt version.

Looks like the line is failing, don't know how it's related to the new rescript version yet.
https://github.com/rescript-lang/rescript-compiler/blob/85028cea2a4947555f7bd8a4dcace2f79c33a50b/scripts/install.js#L132

@DZakh
Copy link
Member Author

DZakh commented Nov 21, 2022

I've found the related PR #5533

Now the workflow uses ubuntu-20.04, that might be the reason.

@DZakh
Copy link
Member Author

DZakh commented Nov 22, 2022

@cknitt Can the PR be done a little bit later #5626 ?

@cknitt
Copy link
Member

cknitt commented Nov 22, 2022

Hmm, I don't know. In theory we could revert this change for the 10.1 release branch and keep it for 11.x only, but that will just postpone the problem a little. The 18.04 Github-hosted runner is already deprecated and will cause intermittent build failures, and, after 2023/04/01, it will not be available anymore at all. What if we need to do a 10.1.x maintenance release then?

If we want Ubuntu 18.04 available for the longer term, somebody would need to deploy and maintain a self-hosted Github actions runner for it.

/cc @cristianoc

@cristianoc
Copy link
Collaborator

Indeed postponing the change seems complicated.

@DZakh
Copy link
Member Author

DZakh commented Nov 22, 2022

Thank you. Kind of an expected answer. The problem is that we use Vercel, and I couldn't figure out how to configure the OS used for builds.
I'll share a solution if manage to make it work.

@zth
Copy link
Collaborator

zth commented Nov 22, 2022

Do we understand what the underlying problem is here...?

@cknitt
Copy link
Member

cknitt commented Nov 22, 2022

Yes, see #5533.

@zth
Copy link
Collaborator

zth commented Nov 22, 2022

Right. Glibc ✝️

@cknitt
Copy link
Member

cknitt commented Dec 3, 2022

@DZakh I discussed this again with @cristianoc as more people have reported being affected by this.

We have decided to indeed revert this change for the 10.1 release branch.
For 11.x, I hope to be able to provide statically linked Linux binaries.

@cknitt cknitt linked a pull request Dec 3, 2022 that will close this issue
@cknitt
Copy link
Member

cknitt commented Jan 6, 2023

@DZakh There is now a version 10.1.1 out with statically linked Linux binaries.

(It is currently still set to next on npm as there are some communication/docs tasks left for the official 10.1 release announcement, see rescript-lang/rescript-lang.org#633.)

@cknitt cknitt closed this as completed Jan 6, 2023
@DZakh
Copy link
Member Author

DZakh commented Jan 6, 2023

Nice, I'm going to try it out today

@DZakh
Copy link
Member Author

DZakh commented Jan 6, 2023

It works 🔥

Build with cache
Before: 3-4 mins
After: 2 mins

Build without cache
Before: 10 mins
After: 4 mins

@cknitt
Copy link
Member

cknitt commented Jan 6, 2023

@DZakh There is now a version 10.1.1 out with statically linked Linux binaries.

Actually I meant linked against the old glibc, not statically linked. Statically linked binaries will be coming with v11 as stated before.

Sorry for the confusion and glad to hear that 10.1.1 is working fine for you! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants