Better error handling for failed requests (transport errors)

Added parameter validation for int range and string length

Author: johnsheehan

RestSharp/Enum.cs

@@ -56,4 +56,11 @@ public enum DateFormat
 	{
 
 	}
+
+	public enum ResponseStatus
+	{
+		None,
+		Success,
+		Error
+	}
 }

RestSharp/RestClient.cs

@@ -117,10 +117,14 @@ private RestResponse GetResponse(RestRequest request) {
 						response = _http.Options(request.GetUri(), @params);
 						break;
 				}
+
+				response.ResponseStatus = ResponseStatus.Success;
 			}
 			catch (Exception ex) {
-				// TODO: handle transport errors better
-				response = new RestResponse { Content = ex.Message };
+				response = new RestResponse { 
+								ErrorMessage = ex.Message,
+								ResponseStatus = ResponseStatus.Error
+						   };
 			}
 
 			return response;

RestSharp/RestResponse.cs

@@ -27,5 +27,17 @@ public class RestResponse
 		public string StatusDescription { get; set; }
 		public Uri ResponseUri { get; set; }
 		public string Server { get; set; }
+
+		private ResponseStatus _responseStatus = ResponseStatus.None;
+		public ResponseStatus ResponseStatus {
+			get {
+				return _responseStatus;
+			}
+			set {
+				_responseStatus = value;
+			}
+		}
+
+		public string ErrorMessage { get; set; }
 	}
 }

RestSharp/RestSharp.csproj

@@ -63,6 +63,7 @@
     <Compile Include="RestClient.cs" />
     <Compile Include="RestRequest.cs" />
     <Compile Include="Authenticators\SimpleAuthenticator.cs" />
+    <Compile Include="Validation\Validate.cs" />
     <Compile Include="Validation\Require.cs" />
   </ItemGroup>
   <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />

RestSharp/Validation/Validate.cs

@@ -0,0 +1,33 @@
+//   Copyright 2009 John Sheehan
+//
+//   Licensed under the Apache License, Version 2.0 (the "License");
+//   you may not use this file except in compliance with the License.
+//   You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+//   Unless required by applicable law or agreed to in writing, software
+//   distributed under the License is distributed on an "AS IS" BASIS,
+//   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+//   See the License for the specific language governing permissions and
+//   limitations under the License.
+
+using System;
+
+namespace RestSharp.Validation
+{
+	public class Validate
+	{
+		public static void IsBetween(int value, int min, int max) {
+			if (value < min || value > max) {
+				throw new ArgumentException(string.Format("Value ({0}) is not between {1} and {2}.", value, min, max));
+			}
+		}
+
+		public static void IsValidLength(string value, int maxSize) {
+			if (value.Length > maxSize) {
+				throw new ArgumentException(string.Format("String is longer than max allowed size ({0}).", maxSize));
+			}
+		}
+	}
+}