Skip to content

Commit 5e84256

Browse files
authored
Merge pull request flutter#7 from davidmorgan/update-lints
Update lints.
2 parents 9a94e8f + 86326fb commit 5e84256

File tree

3 files changed

+15
-3
lines changed

3 files changed

+15
-3
lines changed

CHANGELOG.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
1+
## 1.2.0
2+
3+
- Enforce `unawaited_futures`. Stop enforcing `control_flow_in_finally` and
4+
`throw_in_finally`.
5+
16
## 1.1.0
27

3-
- Moved `analysis_options.yaml` under `lib` so you can import it directly from
8+
- Move `analysis_options.yaml` under `lib` so you can import it directly from
49
your own `analysis_options.yaml`. See `README.md` for example.
510

611
## 1.0.0

README.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,10 @@ and others. See note about Flutter SDK style below.
7070
`avoid_as`
7171
does not reflect standard usage. See note about Flutter SDK style below.
7272

73+
`control_flow_in_finally`
74+
does not offer enough value: people are unlikely to do this by accident,
75+
and there are occasional valid uses.
76+
7377
`empty_statements`
7478
is superfluous, enforcing use of `dartfmt` is sufficient to make empty
7579
statements obvious.
@@ -80,6 +84,10 @@ is superfluous, enforcing use of `dartfmt` is sufficient to make empty
8084
`prefer_final_locals`
8185
does not reflect standard usage.
8286

87+
`throw_in_finally`
88+
does not offer enough value: people are unlikely to do this by accident,
89+
and there are occasional valid uses.
90+
8391
Note on Flutter SDK Style: some lints were created specifically to support
8492
Flutter SDK development. Flutter app developers should instead use standard
8593
Dart style as described in Effective Dart, and should not use these lints.

lib/analysis_options.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,12 @@ linter:
1111
- avoid_relative_lib_imports
1212
- avoid_return_types_on_setters
1313
- avoid_types_as_parameter_names
14-
- control_flow_in_finally
1514
- no_duplicate_case_values
1615
- prefer_contains
1716
- prefer_equal_for_default_values
1817
- prefer_is_not_empty
1918
- recursive_getters
20-
- throw_in_finally
2119
- unrelated_type_equality_checks
2220
- use_rethrow_when_possible
21+
- unawaited_futures
2322
- valid_regexps

0 commit comments

Comments
 (0)