Update for modern analysis (flutter#127)

This should improve the package's health score on Pub

Author: tvolkert

analysis_options.yaml

@@ -1,70 +1,166 @@
 analyzer:
   strong-mode:
     implicit-dynamic: false
-  language:
-    enableSuperMixins: true
   errors:
     # treat missing required parameters as a warning (not a hint)
     missing_required_param: warning
-    # Allow having TODOs in the code
+    # treat missing returns as a warning (not a hint)
+    missing_return: warning
+    # allow having TODOs in the code
     todo: ignore
+    # Ignore analyzer hints for updating pubspecs when using Future or
+    # Stream and not importing dart:async
+    # Please see https://github.com/flutter/flutter/pull/24528 for details.
+    sdk_version_async_exported_from_core: ignore
 
 linter:
   rules:
     # these rules are documented on and in the same order as
     # the Dart Lint rules page to make maintenance easier
-    # http://dart-lang.github.io/linter/lints/
-
-    # === error rules ===
-    - avoid_empty_else
-    - comment_references
-    - cancel_subscriptions
-    - close_sinks
-    - control_flow_in_finally
-    - empty_statements
-    - hash_and_equals
-    - invariant_booleans
-    - iterable_contains_unrelated_type
-    - list_remove_unrelated_type
-    - literal_only_boolean_expressions
-    - test_types_in_equals
-    - throw_in_finally
-    - unrelated_type_equality_checks
-    - valid_regexps
-
-    # === style rules ===
+    # https://github.com/dart-lang/linter/blob/master/example/all.yaml
     - always_declare_return_types
+    - always_put_control_body_on_new_line
+    # - always_put_required_named_parameters_first # we prefer having parameters in the same order as fields https://github.com/flutter/flutter/issues/10219
+    - always_require_non_null_named_parameters
     - always_specify_types
     - annotate_overrides
-    # TODO - avoid_as
+    # - avoid_annotating_with_dynamic # conflicts with always_specify_types
+    # - avoid_as
+    - avoid_bool_literals_in_conditional_expressions
+    # - avoid_catches_without_on_clauses # we do this commonly
+    # - avoid_catching_errors # we do this commonly
+    - avoid_classes_with_only_static_members
+    # - avoid_double_and_int_checks # only useful when targeting JS runtime
+    - avoid_empty_else
+    - avoid_field_initializers_in_const_classes
+    - avoid_function_literals_in_foreach_calls
+    # - avoid_implementing_value_types # not yet tested
     - avoid_init_to_null
+    # - avoid_js_rounded_ints # only useful when targeting JS runtime
+    - avoid_null_checks_in_equality_operators
+    # - avoid_positional_boolean_parameters # not yet tested
+    # - avoid_private_typedef_functions # we prefer having typedef (discussion in https://github.com/flutter/flutter/pull/16356)
+    - avoid_relative_lib_imports
+    - avoid_renaming_method_parameters
     - avoid_return_types_on_setters
+    # - avoid_returning_null # there are plenty of valid reasons to return null
+    # - avoid_returning_null_for_future # not yet tested
+    - avoid_returning_null_for_void
+    # - avoid_returning_this # there are plenty of valid reasons to return this
+    # - avoid_setters_without_getters # not yet tested
+    # - avoid_shadowing_type_parameters # not yet tested
+    # - avoid_single_cascade_in_expression_statements # not yet tested
+    # - avoid_slow_async_io
+    - avoid_types_as_parameter_names
+    # - avoid_types_on_closure_parameters # conflicts with always_specify_types
+    - avoid_unused_constructor_parameters
+    - avoid_void_async
     - await_only_futures
     - camel_case_types
-    - constant_identifier_names
+    - cancel_subscriptions
+    # - cascade_invocations # not yet tested
+    # - close_sinks # not reliable enough
+    # - comment_references # blocked on https://github.com/flutter/flutter/issues/20765
+    # - constant_identifier_names # needs an opt-out https://github.com/dart-lang/linter/issues/204
     - control_flow_in_finally
+    # - curly_braces_in_flow_control_structures # not yet tested
+    # - diagnostic_describe_all_properties # not yet tested
+    - directives_ordering
     - empty_catches
     - empty_constructor_bodies
+    - empty_statements
+    # - file_names # not yet tested
+    - flutter_style_todos
+    - hash_and_equals
     - implementation_imports
+    # - invariant_booleans # too many false positives: https://github.com/dart-lang/linter/issues/811
+    - iterable_contains_unrelated_type
+    # - join_return_with_assignment # not yet tested
     - library_names
     - library_prefixes
+    # - lines_longer_than_80_chars # not yet tested
+    - list_remove_unrelated_type
+    # - literal_only_boolean_expressions # too many false positives: https://github.com/dart-lang/sdk/issues/34181
+    - no_adjacent_strings_in_list
+    - no_duplicate_case_values
     - non_constant_identifier_names
-    - one_member_abstracts
-    - only_throw_errors
+    # - null_closures  # not yet tested
+    # - omit_local_variable_types # opposite of always_specify_types
+    # - one_member_abstracts # too many false positives
+    # - only_throw_errors # https://github.com/flutter/flutter/issues/5792
     - overridden_fields
     - package_api_docs
+    - package_names
     - package_prefixed_library_names
+    # - parameter_assignments # we do this commonly
+    - prefer_adjacent_string_concatenation
+    - prefer_asserts_in_initializer_lists
+    # - prefer_asserts_with_message # not yet tested
+    # - prefer_collection_literals
+    - prefer_conditional_assignment
+    - prefer_const_constructors
+    - prefer_const_constructors_in_immutables
+    - prefer_const_declarations
+    - prefer_const_literals_to_create_immutables
+    # - prefer_constructors_over_static_methods # not yet tested
+    - prefer_contains
+    # - prefer_double_quotes # opposite of prefer_single_quotes
+    - prefer_equal_for_default_values
+    # - prefer_expression_function_bodies # conflicts with https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#consider-using--for-short-functions-and-methods
+    - prefer_final_fields
+    # - prefer_final_in_for_each # not yet tested
+    # - prefer_final_locals
+    # - prefer_for_elements_to_map_fromIterable # not yet tested
+    - prefer_foreach
+    # - prefer_function_declarations_over_variables # not yet tested
+    - prefer_generic_function_type_aliases
+    # - prefer_if_elements_to_conditional_expressions # not yet tested
+    - prefer_if_null_operators
+    - prefer_initializing_formals
+    - prefer_inlined_adds
+    # - prefer_int_literals # not yet tested
+    # - prefer_interpolation_to_compose_strings # not yet tested
+    - prefer_is_empty
     - prefer_is_not_empty
+    - prefer_iterable_whereType
+    # - prefer_mixin # https://github.com/dart-lang/language/issues/32
+    # - prefer_null_aware_operators # disable until NNBD, see https://github.com/flutter/flutter/pull/32711#issuecomment-492930932
+    - prefer_single_quotes
+    - prefer_spread_collections
+    - prefer_typing_uninitialized_variables
+    # - prefer_void_to_null
+    # - provide_deprecation_message # not yet tested
     - public_member_api_docs
+    - recursive_getters
     - slash_for_doc_comments
+    # - sort_child_properties_last # not yet tested
     - sort_constructors_first
+    - sort_pub_dependencies
     - sort_unnamed_constructors_first
-    - super_goes_last
-    - type_annotate_public_apis
+    - test_types_in_equals
+    - throw_in_finally
+    # - type_annotate_public_apis # subset of always_specify_types
     - type_init_formals
-    # TODO - unawaited_futures (https://github.com/dart-lang/linter/issues/419)
+    # - unawaited_futures # too many false positives
+    # - unnecessary_await_in_return # not yet tested
     - unnecessary_brace_in_string_interps
+    - unnecessary_const
     - unnecessary_getters_setters
-
-    # === pub rules ===
-    - package_names
+    # - unnecessary_lambdas # has false positives: https://github.com/dart-lang/linter/issues/498
+    - unnecessary_new
+    - unnecessary_null_aware_assignments
+    - unnecessary_null_in_if_null_operators
+    - unnecessary_overrides
+    - unnecessary_parenthesis
+    - unnecessary_statements
+    - unnecessary_this
+    - unrelated_type_equality_checks
+    # - unsafe_html # not yet tested
+    - use_full_hex_values_for_flutter_colors
+    # - use_function_type_syntax_for_parameters # not yet tested
+    - use_rethrow_when_possible
+    # - use_setters_to_change_properties # not yet tested
+    # - use_string_buffers # has false positives: https://github.com/dart-lang/sdk/issues/34182
+    # - use_to_and_as_if_applicable # has false positives, so we prefer to catch this by code-review
+    - valid_regexps
+    # - void_checks # not yet tested

packages/file/CHANGELOG.md

@@ -1,3 +1,7 @@
+#### 5.0.9
+
+* Fix lints for project health
+
 #### 5.0.8
 
 * Return Uint8List rather than List<int>.

packages/file/README.md

@@ -33,7 +33,7 @@ Use the in-memory file system:
 ```dart
 import 'package:file/memory.dart';
 
-var fs = new MemoryFileSystem();
+var fs = MemoryFileSystem();
 ```
 
 Use the local file system (requires dart:io access):

packages/file/lib/src/backends/chroot/chroot_directory.dart

@@ -11,10 +11,10 @@ class _ChrootDirectory extends _ChrootFileSystemEntity<Directory, io.Directory>
   factory _ChrootDirectory.wrapped(
     ChrootFileSystem fs,
     Directory delegate, {
-    bool relative: false,
+    bool relative = false,
   }) {
     String localPath = fs._local(delegate.path, relative: relative);
-    return new _ChrootDirectory(fs, localPath);
+    return _ChrootDirectory(fs, localPath);
   }
 
   @override
@@ -24,7 +24,7 @@ class _ChrootDirectory extends _ChrootFileSystemEntity<Directory, io.Directory>
   io.Directory _rawDelegate(String path) => fileSystem.delegate.directory(path);
 
   @override
-  Uri get uri => new Uri.directory(path);
+  Uri get uri => Uri.directory(path);
 
   @override
   Future<Directory> rename(String newPath) async {
@@ -83,7 +83,7 @@ class _ChrootDirectory extends _ChrootFileSystemEntity<Directory, io.Directory>
   }
 
   @override
-  Directory get absolute => new _ChrootDirectory(fileSystem, _absolutePath);
+  Directory get absolute => _ChrootDirectory(fileSystem, _absolutePath);
 
   @override
   Directory get parent {
@@ -95,7 +95,7 @@ class _ChrootDirectory extends _ChrootFileSystemEntity<Directory, io.Directory>
   }
 
   @override
-  Future<Directory> create({bool recursive: false}) async {
+  Future<Directory> create({bool recursive = false}) async {
     if (_isLink) {
       switch (await fileSystem.type(path)) {
         case FileSystemEntityType.notFound:
@@ -106,15 +106,15 @@ class _ChrootDirectory extends _ChrootFileSystemEntity<Directory, io.Directory>
           // Nothing to do.
           return this;
         default:
-          throw new AssertionError();
+          throw AssertionError();
       }
     } else {
       return wrap(await delegate.create(recursive: recursive));
     }
   }
 
   @override
-  void createSync({bool recursive: false}) {
+  void createSync({bool recursive = false}) {
     if (_isLink) {
       switch (fileSystem.typeSync(path)) {
         case FileSystemEntityType.notFound:
@@ -125,7 +125,7 @@ class _ChrootDirectory extends _ChrootFileSystemEntity<Directory, io.Directory>
           // Nothing to do.
           return;
         default:
-          throw new AssertionError();
+          throw AssertionError();
       }
     } else {
       delegate.createSync(recursive: recursive);
@@ -134,8 +134,8 @@ class _ChrootDirectory extends _ChrootFileSystemEntity<Directory, io.Directory>
 
   @override
   Stream<FileSystemEntity> list({
-    bool recursive: false,
-    bool followLinks: true,
+    bool recursive = false,
+    bool followLinks = true,
   }) {
     Directory delegate = this.delegate;
     String dirname = delegate.path;
@@ -146,8 +146,8 @@ class _ChrootDirectory extends _ChrootFileSystemEntity<Directory, io.Directory>
 
   @override
   List<FileSystemEntity> listSync({
-    bool recursive: false,
-    bool followLinks: true,
+    bool recursive = false,
+    bool followLinks = true,
   }) {
     Directory delegate = this.delegate;
     String dirname = delegate.path;
@@ -162,13 +162,13 @@ class _ChrootDirectory extends _ChrootFileSystemEntity<Directory, io.Directory>
     String relativePart = ctx.relative(entity.path, from: dirname);
     String entityPath = ctx.join(path, relativePart);
     if (entity is io.File) {
-      return new _ChrootFile(fileSystem, entityPath);
+      return _ChrootFile(fileSystem, entityPath);
     } else if (entity is io.Directory) {
-      return new _ChrootDirectory(fileSystem, entityPath);
+      return _ChrootDirectory(fileSystem, entityPath);
     } else if (entity is io.Link) {
-      return new _ChrootLink(fileSystem, entityPath);
+      return _ChrootLink(fileSystem, entityPath);
     }
-    throw new FileSystemException('Unsupported type: $entity', entity.path);
+    throw FileSystemException('Unsupported type: $entity', entity.path);
   }
 
   @override