Skip to content

Commit 856c083

Browse files
authored
Remove upper case constants (flutter#13)
Remove usage of upper-case constants. Updates SDK version to 2.0.0-dev.17.0
1 parent 158826c commit 856c083

File tree

4 files changed

+26
-24
lines changed

4 files changed

+26
-24
lines changed

.travis.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@ language: dart
22

33
dart:
44
- dev
5-
- stable
6-
- 1.23.0
75

86
dart_task:
97
- test: --platform vm

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 1.3.5
2+
3+
- Updated SDK version to 2.0.0-dev.17.0
4+
15
## 1.3.4
26

37
* Modify code to eliminate Future flattening.

pubspec.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
name: pool
2-
version: 1.3.4
2+
version: 1.3.5
33
author: Dart Team <[email protected]>
44
description: A class for managing a finite pool of resources.
55
homepage: https://github.com/dart-lang/pool
66
dependencies:
77
async: ">=1.4.0 <3.0.0"
88
stack_trace: ">=0.9.2 <2.0.0"
99
environment:
10-
sdk: ">=1.23.0 <2.0.0"
10+
sdk: ">=2.0.0-dev.17.0 <2.0.0"
1111
dev_dependencies:
1212
fake_async: ">=0.1.0 <0.2.0"
1313
test: ">=0.12.0 <0.13.0"

test/pool_test.dart

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -177,11 +177,11 @@ void main() {
177177
var resource = await pool.request();
178178
var onReleaseCalled = false;
179179
resource.allowRelease(() => onReleaseCalled = true);
180-
await new Future.delayed(Duration.ZERO);
180+
await new Future.delayed(Duration.zero);
181181
expect(onReleaseCalled, isFalse);
182182

183183
expect(pool.request(), completes);
184-
await new Future.delayed(Duration.ZERO);
184+
await new Future.delayed(Duration.zero);
185185
expect(onReleaseCalled, isTrue);
186186
});
187187

@@ -195,7 +195,7 @@ void main() {
195195

196196
var onReleaseCalled = false;
197197
resource.allowRelease(() => onReleaseCalled = true);
198-
await new Future.delayed(Duration.ZERO);
198+
await new Future.delayed(Duration.zero);
199199
expect(onReleaseCalled, isTrue);
200200
});
201201

@@ -208,11 +208,11 @@ void main() {
208208

209209
var completer = new Completer();
210210
resource.allowRelease(() => completer.future);
211-
await new Future.delayed(Duration.ZERO);
211+
await new Future.delayed(Duration.zero);
212212
expect(requestComplete, isFalse);
213213

214214
completer.complete();
215-
await new Future.delayed(Duration.ZERO);
215+
await new Future.delayed(Duration.zero);
216216
expect(requestComplete, isTrue);
217217
});
218218

@@ -233,7 +233,7 @@ void main() {
233233
onRelease1Called = true;
234234
return completer1.future;
235235
});
236-
await new Future.delayed(Duration.ZERO);
236+
await new Future.delayed(Duration.zero);
237237
expect(onRelease1Called, isTrue);
238238

239239
var onRelease2Called = false;
@@ -242,7 +242,7 @@ void main() {
242242
onRelease2Called = true;
243243
return completer2.future;
244244
});
245-
await new Future.delayed(Duration.ZERO);
245+
await new Future.delayed(Duration.zero);
246246
expect(onRelease2Called, isTrue);
247247
expect(request1Complete, isFalse);
248248
expect(request2Complete, isFalse);
@@ -251,12 +251,12 @@ void main() {
251251
// was triggered by the second blocking request, it should complete the
252252
// first one to preserve ordering.
253253
completer2.complete();
254-
await new Future.delayed(Duration.ZERO);
254+
await new Future.delayed(Duration.zero);
255255
expect(request1Complete, isTrue);
256256
expect(request2Complete, isFalse);
257257

258258
completer1.complete();
259-
await new Future.delayed(Duration.ZERO);
259+
await new Future.delayed(Duration.zero);
260260
expect(request1Complete, isTrue);
261261
expect(request2Complete, isTrue);
262262
});
@@ -286,7 +286,7 @@ void main() {
286286
var resource = await pool.request();
287287
resource.release();
288288

289-
await new Future.delayed(Duration.ZERO);
289+
await new Future.delayed(Duration.zero);
290290
});
291291

292292
group("close()", () {
@@ -323,7 +323,7 @@ void main() {
323323
expect(pool.close(), completes);
324324

325325
resource1.allowRelease(() => completer.future);
326-
await new Future.delayed(Duration.ZERO);
326+
await new Future.delayed(Duration.zero);
327327

328328
completer.complete();
329329
});
@@ -347,11 +347,11 @@ void main() {
347347

348348
resource1Released = true;
349349
resource1.release();
350-
await new Future.delayed(Duration.ZERO);
350+
await new Future.delayed(Duration.zero);
351351

352352
resource2Released = true;
353353
resource2.release();
354-
await new Future.delayed(Duration.ZERO);
354+
await new Future.delayed(Duration.zero);
355355

356356
var resource3 = await resource3Future;
357357
resource3Released = true;
@@ -372,10 +372,10 @@ void main() {
372372
}),
373373
completes);
374374

375-
await new Future.delayed(Duration.ZERO);
375+
await new Future.delayed(Duration.zero);
376376
pool.close();
377377

378-
await new Future.delayed(Duration.ZERO);
378+
await new Future.delayed(Duration.zero);
379379
completer.complete();
380380
});
381381

@@ -396,10 +396,10 @@ void main() {
396396
}),
397397
completes);
398398

399-
await new Future.delayed(Duration.ZERO);
399+
await new Future.delayed(Duration.zero);
400400
completer1.complete();
401401

402-
await new Future.delayed(Duration.ZERO);
402+
await new Future.delayed(Duration.zero);
403403
completer2.complete();
404404
});
405405

@@ -414,10 +414,10 @@ void main() {
414414
}),
415415
completes);
416416

417-
await new Future.delayed(Duration.ZERO);
417+
await new Future.delayed(Duration.zero);
418418
resource.allowRelease(() => completer.future);
419419

420-
await new Future.delayed(Duration.ZERO);
420+
await new Future.delayed(Duration.zero);
421421
completer.complete();
422422
});
423423

@@ -431,7 +431,7 @@ void main() {
431431
expect(pool.done, throwsA("oh no!"));
432432
expect(pool.close(), throwsA("oh no!"));
433433

434-
await new Future.delayed(Duration.ZERO);
434+
await new Future.delayed(Duration.zero);
435435
completer.completeError("oh no!");
436436
});
437437
});

0 commit comments

Comments
 (0)