Skip to content

Commit c2dac58

Browse files
authored
Merge pull request flutter#112 from dart-lang/mit-mit-64bit
Skip 64-bit json test on browser platforms
2 parents cf7a731 + 0b92957 commit c2dac58

File tree

3 files changed

+27
-16
lines changed

3 files changed

+27
-16
lines changed

test/json_test.dart

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,9 @@
44
library json_test;
55

66
import 'dart:convert';
7-
import 'package:fixnum/fixnum.dart' show Int64;
87
import 'package:test/test.dart';
98

10-
import 'mock_util.dart' show MockMessage, mockInfo;
11-
12-
class T extends MockMessage {
13-
get info_ => _info;
14-
static final _info = mockInfo("T", () => new T());
15-
}
9+
import 'mock_util.dart' show T;
1610

1711
main() {
1812
T example = new T()
@@ -40,15 +34,6 @@ main() {
4034
t.mergeFromJsonMap({"1": 123, "2": "hello"});
4135
checkMessage(t);
4236
});
43-
44-
test('testInt64JsonEncoding', () {
45-
final value = new Int64(1234567890123456789);
46-
final t = new T()..int64 = value;
47-
final encoded = t.writeToJsonMap();
48-
expect(encoded["5"], "$value");
49-
final decoded = new T()..mergeFromJsonMap(encoded);
50-
expect(decoded.int64, value);
51-
});
5237
}
5338

5439
checkJsonMap(Map m) {

test/json_vm_test.dart

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
// VM-specific smoke tests for the GeneratedMessage JSON API.
2+
//
3+
// These tests will be skipped on js, as the dart2js platform
4+
// does not support 64-bit ints.
5+
@TestOn('!js')
6+
7+
import 'package:fixnum/fixnum.dart' show Int64;
8+
import 'package:test/test.dart';
9+
10+
import 'mock_util.dart' show T;
11+
12+
main() {
13+
test('testInt64JsonEncoding', () {
14+
final value = new Int64(1234567890123456789);
15+
final t = new T()..int64 = value;
16+
final encoded = t.writeToJsonMap();
17+
expect(encoded["5"], "$value");
18+
final decoded = new T()..mergeFromJsonMap(encoded);
19+
expect(decoded.int64, value);
20+
});
21+
}

test/mock_util.dart

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,3 +41,8 @@ abstract class MockMessage extends GeneratedMessage {
4141
return create()..mergeFromMessage(this);
4242
}
4343
}
44+
45+
class T extends MockMessage {
46+
get info_ => _info;
47+
static final _info = mockInfo("T", () => new T());
48+
}

0 commit comments

Comments
 (0)