Skip to content

Added better types for typescript #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 17, 2019
Merged

Added better types for typescript #160

merged 2 commits into from
Sep 17, 2019

Conversation

ChristianStornowski
Copy link
Contributor

Added possibility to use:

import VueScrollTo from "vue-scrollto";

VueScrollTo.scrollTo(element.$el, {offset: -125, duration: 1});

@rigor789
Copy link
Owner

Hey @ChristianStornowski thanks for the PR!

I'm not a TS user (yet), but I wonder if these type definitions will account for the returned cancel function from this.$scrollTo and VueScrollTo.scrollTo?

@ChristianStornowski
Copy link
Contributor Author

Sorry. I missed this cancel function. :-/
I added this function

@rigor789 rigor789 merged commit f6a6596 into rigor789:master Sep 17, 2019
@rigor789
Copy link
Owner

🎉 This PR is included in version 2.17.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants