Skip to content

Commit 906b964

Browse files
ngzhianCommit Bot
authored and
Commit Bot
committed
[wasm-simd] Move i64x2.eq out of post mvp
This is merged into the proposal: WebAssembly/simd#419 (comment). Bug: v8:11215 Change-Id: Ibe37c4f8a977ab9af1cc2dd083f1ebb88b27acfa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2647986 Reviewed-by: Deepti Gandluri <[email protected]> Commit-Queue: Zhi An Ng <[email protected]> Cr-Commit-Position: refs/heads/master@{#72333}
1 parent 1fa2b9e commit 906b964

File tree

3 files changed

+1
-16
lines changed

3 files changed

+1
-16
lines changed

src/compiler/backend/instruction-selector.cc

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2751,14 +2751,6 @@ void InstructionSelector::VisitF32x4Qfms(Node* node) { UNIMPLEMENTED(); }
27512751
#endif // !V8_TARGET_ARCH_ARM64
27522752
#endif // !V8_TARGET_ARCH_X64 && !V8_TARGET_ARCH_S390X
27532753

2754-
#if !V8_TARGET_ARCH_X64 && !V8_TARGET_ARCH_S390X && !V8_TARGET_ARCH_ARM64 && \
2755-
!V8_TARGET_ARCH_IA32 && !V8_TARGET_ARCH_ARM && !V8_TARGET_ARCH_MIPS64 && \
2756-
!V8_TARGET_ARCH_MIPS
2757-
void InstructionSelector::VisitI64x2Eq(Node* node) { UNIMPLEMENTED(); }
2758-
#endif // !V8_TARGET_ARCH_X64 && !V8_TARGET_ARCH_S390X && !V8_TARGET_ARCH_ARM64
2759-
// && !V8_TARGET_ARCH_IA32 && !V8_TARGET_ARCH_ARM
2760-
// && !V8_TARGET_ARCH_MIPS64 && !V8_TARGET_ARCH_MIPS
2761-
27622754
#if !V8_TARGET_ARCH_ARM64 && !V8_TARGET_ARCH_X64 && !V8_TARGET_ARCH_IA32
27632755
// TODO(v8:11168): Prototyping prefetch.
27642756
void InstructionSelector::VisitPrefetchTemporal(Node* node) { UNIMPLEMENTED(); }

src/wasm/wasm-opcodes.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -337,6 +337,7 @@ bool V8_EXPORT_PRIVATE IsJSCompatibleSignature(const FunctionSig* sig,
337337
V(I32x4LeU, 0xfd3e, s_ss) \
338338
V(I32x4GeS, 0xfd3f, s_ss) \
339339
V(I32x4GeU, 0xfd40, s_ss) \
340+
V(I64x2Eq, 0xfdc0, s_ss) \
340341
V(F32x4Eq, 0xfd41, s_ss) \
341342
V(F32x4Ne, 0xfd42, s_ss) \
342343
V(F32x4Lt, 0xfd43, s_ss) \
@@ -505,7 +506,6 @@ bool V8_EXPORT_PRIVATE IsJSCompatibleSignature(const FunctionSig* sig,
505506
V(I32x4ExtAddPairwiseI16x8U, 0xfda6, s_s) \
506507
V(I16x8ExtAddPairwiseI8x16S, 0xfdc2, s_s) \
507508
V(I16x8ExtAddPairwiseI8x16U, 0xfdc3, s_s) \
508-
V(I64x2Eq, 0xfdc0, s_ss) \
509509
V(F32x4Qfma, 0xfdb4, s_sss) \
510510
V(F32x4Qfms, 0xfdd4, s_sss) \
511511
V(F64x2Qfma, 0xfdfe, s_sss) \

test/cctest/wasm/test-run-wasm-simd.cc

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1004,7 +1004,6 @@ WASM_SIMD_TEST(I64x2ShrU) {
10041004

10051005
void RunI64x2BinOpTest(TestExecutionTier execution_tier, LowerSimd lower_simd,
10061006
WasmOpcode opcode, Int64BinOp expected_op) {
1007-
FLAG_SCOPE(wasm_simd_post_mvp);
10081007
WasmRunner<int32_t, int64_t, int64_t> r(execution_tier, lower_simd);
10091008
// Global to hold output.
10101009
int64_t* g = r.builder().AddGlobal<int64_t>(kWasmS128);
@@ -1039,15 +1038,9 @@ WASM_SIMD_TEST(I64x2Sub) {
10391038
base::SubWithWraparound);
10401039
}
10411040

1042-
#if V8_TARGET_ARCH_X64 || V8_TARGET_ARCH_ARM64 || V8_TARGET_ARCH_S390X || \
1043-
V8_TARGET_ARCH_IA32 || V8_TARGET_ARCH_ARM || V8_TARGET_ARCH_MIPS64 || \
1044-
V8_TARGET_ARCH_MIPS
10451041
WASM_SIMD_TEST_NO_LOWERING(I64x2Eq) {
10461042
RunI64x2BinOpTest(execution_tier, lower_simd, kExprI64x2Eq, Equal);
10471043
}
1048-
#endif // V8_TARGET_ARCH_X64 || V8_TARGET_ARCH_ARM64 || V8_TARGET_ARCH_S390X ||
1049-
// V8_TARGET_ARCH_IA32 || V8_TARGET_ARCH_ARM || V8_TARGET_ARCH_MIPS64 ||
1050-
// V8_TARGET_ARCH_MIPS
10511044

10521045
WASM_SIMD_TEST(F64x2Splat) {
10531046
WasmRunner<int32_t, double> r(execution_tier, lower_simd);

0 commit comments

Comments
 (0)