Skip to content

Commit 6e03730

Browse files
Fixes found by Copilot review - Remove _PARAM in norm rule name and fix .PHONY in Makefile for update-refs target (riscv#2680)
Signed-off-by: James Ball <jameball@qti.qualcomm.com>
1 parent 4ac6bdf commit 6e03730

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

Makefile

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ REQUIRES := --require=asciidoctor-bibtex \
131131
--require=asciidoctor-sail
132132

133133
.PHONY: all build clean build-container build-no-container build-docs build-pdf build-html build-epub build-tags docker-pull-latest submodule-check
134-
.PHONY: build-norm-rules build-norm-rules-json build-norm-rules-html check-tags update-ref-tags
134+
.PHONY: build-norm-rules build-norm-rules-json build-norm-rules-html check-tags update-ref
135135

136136
all: build
137137

@@ -149,6 +149,8 @@ build-tags: $(DOCS_NORM_TAGS)
149149
check-tags:
150150
@bash ./scripts/check-tag-changes.sh
151151

152+
# Copy built normative tags JSON files to ref directory and use sed to ensure they end with a newline.
153+
# Required by GitHub pre-commit checks for this repo.
152154
update-ref: $(DOCS_NORM_TAGS)
153155
cp -f $(DOCS_NORM_TAGS) ref
154156
sed -i -e '$$a\' ref/*.json

normative_rule_defs/machine.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1401,7 +1401,7 @@ normative_rule_definitions:
14011401
tag: "norm:uncached_ignores_cached"
14021402

14031403
# Physical Memory Protection (PMP)
1404-
- name: PMP_GRANULARITY_PARAM
1404+
- name: PMP_GRANULARITY
14051405
summary: Minimum PMP region granularity supported by the platform
14061406
tags: ["norm:pmp_granularity"]
14071407
impl-def-behavior: true

0 commit comments

Comments
 (0)