Skip to content

Commit 73db864

Browse files
committed
fix
1 parent 6857085 commit 73db864

File tree

8 files changed

+13
-15
lines changed

8 files changed

+13
-15
lines changed

Cargo.lock

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/batch/src/execution/grpc_exchange.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ impl Debug for GrpcExchangeSource {
7272
}
7373

7474
impl ExchangeSource for GrpcExchangeSource {
75-
type TakeDataFuture<'a> = impl Future<Output = Result<Option<DataChunk>>>;
75+
type TakeDataFuture<'a> = impl Future<Output = Result<Option<DataChunk>>> + 'a;
7676

7777
fn take_data(&mut self) -> Self::TakeDataFuture<'_> {
7878
async {

src/batch/src/execution/local_exchange.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ impl Debug for LocalExchangeSource {
5252
}
5353

5454
impl ExchangeSource for LocalExchangeSource {
55-
type TakeDataFuture<'a> = impl Future<Output = Result<Option<DataChunk>>>;
55+
type TakeDataFuture<'a> = impl Future<Output = Result<Option<DataChunk>>> + 'a;
5656

5757
fn take_data(&mut self) -> Self::TakeDataFuture<'_> {
5858
async {

src/batch/src/executor/test_utils.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,7 @@ impl FakeExchangeSource {
251251
}
252252

253253
impl ExchangeSource for FakeExchangeSource {
254-
type TakeDataFuture<'a> = impl Future<Output = Result<Option<DataChunk>>>;
254+
type TakeDataFuture<'a> = impl Future<Output = Result<Option<DataChunk>>> + 'a;
255255

256256
fn take_data(&mut self) -> Self::TakeDataFuture<'_> {
257257
async {

src/batch/src/task/broadcast_channel.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ impl Debug for BroadcastSender {
4242
}
4343

4444
impl ChanSender for BroadcastSender {
45-
type SendFuture<'a> = impl Future<Output = BatchResult<()>>;
45+
type SendFuture<'a> = impl Future<Output = BatchResult<()>> + 'a;
4646

4747
fn send(&mut self, chunk: Option<DataChunk>) -> Self::SendFuture<'_> {
4848
async move {
@@ -65,7 +65,7 @@ pub struct BroadcastReceiver {
6565
}
6666

6767
impl ChanReceiver for BroadcastReceiver {
68-
type RecvFuture<'a> = impl Future<Output = Result<Option<DataChunkInChannel>>>;
68+
type RecvFuture<'a> = impl Future<Output = Result<Option<DataChunkInChannel>>> + 'a;
6969

7070
fn recv(&mut self) -> Self::RecvFuture<'_> {
7171
async move {

src/batch/src/task/fifo_channel.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ pub struct FifoReceiver {
3939
}
4040

4141
impl ChanSender for FifoSender {
42-
type SendFuture<'a> = impl Future<Output = BatchResult<()>>;
42+
type SendFuture<'a> = impl Future<Output = BatchResult<()>> + 'a;
4343

4444
fn send(&mut self, chunk: Option<DataChunk>) -> Self::SendFuture<'_> {
4545
async {
@@ -52,7 +52,7 @@ impl ChanSender for FifoSender {
5252
}
5353

5454
impl ChanReceiver for FifoReceiver {
55-
type RecvFuture<'a> = impl Future<Output = Result<Option<DataChunkInChannel>>>;
55+
type RecvFuture<'a> = impl Future<Output = Result<Option<DataChunkInChannel>>> + 'a;
5656

5757
fn recv(&mut self) -> Self::RecvFuture<'_> {
5858
async move {

src/batch/src/task/hash_shuffle_channel.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ fn generate_new_data_chunks(
105105
}
106106

107107
impl ChanSender for HashShuffleSender {
108-
type SendFuture<'a> = impl Future<Output = BatchResult<()>>;
108+
type SendFuture<'a> = impl Future<Output = BatchResult<()>> + 'a;
109109

110110
fn send(&mut self, chunk: Option<DataChunk>) -> Self::SendFuture<'_> {
111111
async move {
@@ -150,7 +150,7 @@ impl HashShuffleSender {
150150
}
151151

152152
impl ChanReceiver for HashShuffleReceiver {
153-
type RecvFuture<'a> = impl Future<Output = Result<Option<DataChunkInChannel>>>;
153+
type RecvFuture<'a> = impl Future<Output = Result<Option<DataChunkInChannel>>> + 'a;
154154

155155
fn recv(&mut self) -> Self::RecvFuture<'_> {
156156
async move {

src/storage/src/hummock/iterator/merge_inner.rs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -302,10 +302,8 @@ impl<I: HummockIterator> UnorderedMergeIteratorInner<I> {
302302
// before returning.
303303

304304
// TODO(chi): workaround for Rust toolchain 2022-10-16, removed boxed() later
305-
306-
let f = unsafe_boxed_static_future(node.iter.next());
307-
308-
match f.await {
305+
306+
match unsafe_boxed_static_future(node.iter.next()).await {
309307
Ok(_) => {}
310308
Err(e) => {
311309
// If the iterator returns error, we should clear the heap, so that this

0 commit comments

Comments
 (0)