test: use tmpdir.resolve() in fs tests

PR-URL: nodejs#49125
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>

Author: LiviaMedeiros

test/parallel/test-fs-promises-file-handle-aggregate-errors.js

@@ -7,7 +7,6 @@ const tmpdir = require('../common/tmpdir');
 // The following tests validate aggregate errors are thrown correctly
 // when both an operation and close throw.
 
-const path = require('path');
 const {
   readFile,
   writeFile,
@@ -23,7 +22,7 @@ const originalFd = Object.getOwnPropertyDescriptor(FileHandle.prototype, 'fd');
 
 let count = 0;
 async function createFile() {
-  const filePath = path.join(tmpdir.path, `aggregate_errors_${++count}.txt`);
+  const filePath = tmpdir.resolve(`aggregate_errors_${++count}.txt`);
   await writeFile(filePath, 'content');
   return filePath;
 }

test/parallel/test-fs-promises-file-handle-close-errors.js

@@ -7,7 +7,6 @@ const tmpdir = require('../common/tmpdir');
 // The following tests validate aggregate errors are thrown correctly
 // when both an operation and close throw.
 
-const path = require('path');
 const {
   readFile,
   writeFile,
@@ -23,7 +22,7 @@ const originalFd = Object.getOwnPropertyDescriptor(FileHandle.prototype, 'fd');
 
 let count = 0;
 async function createFile() {
-  const filePath = path.join(tmpdir.path, `close_errors_${++count}.txt`);
+  const filePath = tmpdir.resolve(`close_errors_${++count}.txt`);
   await writeFile(filePath, 'content');
   return filePath;
 }

test/parallel/test-fs-promises-file-handle-op-errors.js

@@ -7,7 +7,6 @@ const tmpdir = require('../common/tmpdir');
 // The following tests validate aggregate errors are thrown correctly
 // when both an operation and close throw.
 
-const path = require('path');
 const {
   readFile,
   writeFile,
@@ -23,7 +22,7 @@ const originalFd = Object.getOwnPropertyDescriptor(FileHandle.prototype, 'fd');
 
 let count = 0;
 async function createFile() {
-  const filePath = path.join(tmpdir.path, `op_errors_${++count}.txt`);
+  const filePath = tmpdir.resolve(`op_errors_${++count}.txt`);
   await writeFile(filePath, 'content');
   return filePath;
 }

test/parallel/test-fs-promises-file-handle-read-worker.js

@@ -2,9 +2,8 @@
 const common = require('../common');
 const fs = require('fs');
 const assert = require('assert');
-const path = require('path');
 const tmpdir = require('../common/tmpdir');
-const file = path.join(tmpdir.path, 'read_stream_filehandle_worker.txt');
+const file = tmpdir.resolve('read_stream_filehandle_worker.txt');
 const input = 'hello world';
 const { Worker, isMainThread, workerData } = require('worker_threads');
 

test/parallel/test-fs-promises-file-handle-readLines.mjs

@@ -3,11 +3,10 @@ import tmpdir from '../common/tmpdir.js';
 
 import assert from 'node:assert';
 import { open, writeFile } from 'node:fs/promises';
-import path from 'node:path';
 
 tmpdir.refresh();
 
-const filePath = path.join(tmpdir.path, 'file.txt');
+const filePath = tmpdir.resolve('file.txt');
 
 await writeFile(filePath, '1\n\n2\n');
 

test/parallel/test-fs-promises-file-handle-stat.js

@@ -6,14 +6,13 @@ const common = require('../common');
 // FileHandle.stat method.
 
 const { open } = require('fs').promises;
-const path = require('path');
 const tmpdir = require('../common/tmpdir');
 const assert = require('assert');
 
 tmpdir.refresh();
 
 async function validateStat() {
-  const filePath = path.resolve(tmpdir.path, 'tmp-read-file.txt');
+  const filePath = tmpdir.resolve('tmp-read-file.txt');
   const fileHandle = await open(filePath, 'w+');
   const stats = await fileHandle.stat();
   assert.ok(stats.mtime instanceof Date);

test/parallel/test-fs-promises-file-handle-sync.js

@@ -5,11 +5,10 @@ const fixtures = require('../common/fixtures');
 const tmpdir = require('../common/tmpdir');
 
 const { access, copyFile, open } = require('fs').promises;
-const path = require('path');
 
 async function validate() {
   tmpdir.refresh();
-  const dest = path.resolve(tmpdir.path, 'baz.js');
+  const dest = tmpdir.resolve('baz.js');
   await assert.rejects(
     copyFile(fixtures.path('baz.js'), dest, 'r'),
     {

test/parallel/test-fs-promises-file-handle-truncate.js

@@ -2,15 +2,14 @@
 
 const common = require('../common');
 const assert = require('assert');
-const path = require('path');
 const { open, readFile } = require('fs').promises;
 const tmpdir = require('../common/tmpdir');
 
 tmpdir.refresh();
 
 async function validateTruncate() {
   const text = 'Hello world';
-  const filename = path.resolve(tmpdir.path, 'truncate-file.txt');
+  const filename = tmpdir.resolve('truncate-file.txt');
   const fileHandle = await open(filename, 'w+');
 
   const buffer = Buffer.from(text, 'utf8');

test/parallel/test-fs-promises-readfile-with-fd.js

@@ -5,14 +5,13 @@
 
 const common = require('../common');
 const assert = require('assert');
-const path = require('path');
 const { writeFileSync } = require('fs');
 const { open } = require('fs').promises;
 
 const tmpdir = require('../common/tmpdir');
 tmpdir.refresh();
 
-const fn = path.join(tmpdir.path, 'test.txt');
+const fn = tmpdir.resolve('test.txt');
 writeFileSync(fn, 'Hello World');
 
 async function readFileTest() {

test/parallel/test-fs-promises-readfile.js

@@ -4,14 +4,13 @@
 const common = require('../common');
 
 const assert = require('assert');
-const path = require('path');
 const { writeFile, readFile } = require('fs').promises;
 const tmpdir = require('../common/tmpdir');
 const { internalBinding } = require('internal/test/binding');
 const fsBinding = internalBinding('fs');
 tmpdir.refresh();
 
-const fn = path.join(tmpdir.path, 'large-file');
+const fn = tmpdir.resolve('large-file');
 
 // Creating large buffer with random content
 const largeBuffer = Buffer.from(