Reverts flutter#152 and flutter#150 until upstream repos are updated (flutter#156)

* Revert "Follow-up to switch to Fuchsia's ICU (flutter#152)"
* Revert "Prepare for switch to Fuchsia ICU (flutter#150)"

Author: goderbauer

build/config/BUILD.gn

@@ -5,7 +5,6 @@
 import("//build/config/allocator.gni")
 import("//build/config/crypto.gni")
 import("//build/config/features.gni")
-import("//build/config/profiler.gni")
 import("//build/config/ui.gni")
 
 declare_args() {
@@ -222,37 +221,3 @@ config("precompiled_headers") {
     cflags = [ "/FI$precompiled_header" ]
   }
 }
-
-# This config causes functions not to be automatically exported from shared
-# libraries. By default, all symbols are exported but this means there are
-# lots of exports that slow everything down. In general we explicitly mark
-# which functiosn we want to export from components.
-#
-# Some third_party code assumes all functions are exported so this is separated
-# into its own config so such libraries can remove this config to make symbols
-# public again.
-#
-# See http://gcc.gnu.org/wiki/Visibility
-config("symbol_visibility_hidden") {
-  # Note that -fvisibility-inlines-hidden is set globally in the compiler
-  # config since that can almost always be applied.
-  if (is_posix && !enable_profiling) {
-    cflags = [ "-fvisibility=hidden" ]
-  }
-}
-
-# Allows turning Run-Time Type Identification on or off.
-config("rtti") {
-  if (is_win) {
-    cflags_cc = [ "/GR" ]
-  }
-}
-config("no_rtti") {
-  if (is_win) {
-    cflags_cc = [ "/GR-" ]
-  } else {
-    rtti_flags = [ "-fno-rtti" ]
-    cflags_cc = rtti_flags
-    cflags_objcc = rtti_flags
-  }
-}

build/config/BUILDCONFIG.gn

@@ -411,9 +411,8 @@ _native_compiler_configs = [
   "//build/config/compiler:compiler_arm_fpu",
   "//build/config/compiler:chromium_code",
   "//build/config/compiler:default_include_dirs",
+  "//build/config/compiler:no_rtti",
   "//build/config/compiler:runtime_library",
-  "//build/config:no_rtti",
-  "//build/config:symbol_visibility_hidden",
 ]
 if (is_win) {
   _native_compiler_configs += [
@@ -427,6 +426,7 @@ if (is_win) {
 if (is_posix) {
   _native_compiler_configs += [
     "//build/config/gcc:no_exceptions",
+    "//build/config/gcc:symbol_visibility_hidden",
   ]
 }
 
@@ -561,14 +561,6 @@ set_defaults("test") {
   }
 }
 
-# Some library targets may be built as different type depending on the target
-# platform. This variable specifies the default library type for each target.
-if (is_fuchsia) {
-  default_library_type = "shared_library"
-} else {
-  default_library_type = "static_library"
-}
-
 # ==============================================================================
 # TOOLCHAIN SETUP
 # ==============================================================================

build/config/compiler/BUILD.gn

@@ -681,6 +681,25 @@ config("no_chromium_code") {
   cflags_cc += default_warning_flags_cc
 }
 
+# rtti ------------------------------------------------------------------------
+#
+# Allows turning Run-Time Type Identification on or off.
+
+config("rtti") {
+  if (is_win) {
+    cflags_cc = [ "/GR" ]
+  }
+}
+config("no_rtti") {
+  if (is_win) {
+    cflags_cc = [ "/GR-" ]
+  } else {
+    rtti_flags = [ "-fno-rtti" ]
+    cflags_cc = rtti_flags
+    cflags_objcc = rtti_flags
+  }
+}
+
 # Warnings ---------------------------------------------------------------------
 
 # This will generate warnings when using Clang if code generates exit-time

build/config/gcc/BUILD.gn

@@ -4,6 +4,24 @@
 
 import("//build/config/profiler.gni")
 
+# This config causes functions not to be automatically exported from shared
+# libraries. By default, all symbols are exported but this means there are
+# lots of exports that slow everything down. In general we explicitly mark
+# which functiosn we want to export from components.
+#
+# Some third_party code assumes all functions are exported so this is separated
+# into its own config so such libraries can remove this config to make symbols
+# public again.
+#
+# See http://gcc.gnu.org/wiki/Visibility
+config("symbol_visibility_hidden") {
+  # Note that -fvisibility-inlines-hidden is set globally in the compiler
+  # config since that can almost always be applied.
+  if (!enable_profiling) {
+    cflags = [ "-fvisibility=hidden" ]
+  }
+}
+
 # Settings for executables and shared libraries.
 config("executable_ldconfig") {
   if (is_android) {