Add default visitor for ALL_RULES

Author: rmosolgo

lib/graphql/static_validation.rb

@@ -4,11 +4,13 @@
 require "graphql/static_validation/validator"
 require "graphql/static_validation/validation_context"
 require "graphql/static_validation/literal_validator"
-require "graphql/static_validation/visitor"
+require "graphql/static_validation/base_visitor"
+require "graphql/static_validation/no_validate_visitor"
 
 rules_glob = File.expand_path("../static_validation/rules/*.rb", __FILE__)
 Dir.glob(rules_glob).each do |file|
   require(file)
 end
 
 require "graphql/static_validation/all_rules"
+require "graphql/static_validation/default_visitor"

lib/graphql/static_validation/visitor.rb renamed to lib/graphql/static_validation/base_visitor.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 module GraphQL
   module StaticValidation
-    class Visitor < GraphQL::Language::Visitor
+    class BaseVisitor < GraphQL::Language::Visitor
       def initialize(document, context)
         @path = []
         @object_types = []

lib/graphql/static_validation/default_visitor.rb

@@ -0,0 +1,12 @@
+# frozen_string_literal: true
+module GraphQL
+  module StaticValidation
+    class DefaultVisitor < BaseVisitor
+      StaticValidation::ALL_RULES.reverse_each do |r|
+        include(r)
+      end
+
+      prepend(ContextMethods)
+    end
+  end
+end

lib/graphql/static_validation/no_validate_visitor.rb

@@ -0,0 +1,8 @@
+# frozen_string_literal: true
+module GraphQL
+  module StaticValidation
+    class NoValidateVisitor < StaticValidation::BaseVisitor
+      prepend(StaticValidation::BaseVisitor::ContextMethods)
+    end
+  end
+end

lib/graphql/static_validation/validator.rb

@@ -24,18 +24,24 @@ def initialize(schema:, rules: GraphQL::StaticValidation::ALL_RULES)
       def validate(query, validate: true)
         query.trace("validate", { validate: validate, query: query }) do
 
-          # TODO make a default class to use when all rules are chosen
-          visitor_class = Class.new(StaticValidation::Visitor)
-          if validate
+          visitor_class = if validate == false
+            # This visitor tracks context info, but doesn't apply any rules
+            StaticValidation::NoValidateVisitor
+          elsif @rules == ALL_RULES
+            # This visitor applies the default rules
+            StaticValidation::DefaultVisitor
+          else
+            # Create a visitor on the fly
+            custom_class = Class.new(StaticValidation::BaseVisitor)
             @rules.reverse_each do |r|
               if !r.is_a?(Class)
-                visitor_class.include(r)
+                custom_class.include(r)
               end
             end
+            custom_class.prepend(StaticValidation::BaseVisitor::ContextMethods)
+            custom_class
           end
 
-          visitor_class.prepend(StaticValidation::Visitor::ContextMethods)
-
           context = GraphQL::StaticValidation::ValidationContext.new(query, visitor_class)
           rewrite = GraphQL::InternalRepresentation::Rewrite.new
 
@@ -44,6 +50,7 @@ def validate(query, validate: true)
 
           # If the caller opted out of validation, don't attach these
           if validate
+            # Attach legacy-style rules
             @rules.each do |rule_class_or_module|
               if rule_class_or_module.method_defined?(:validate)
                 rule_class_or_module.new.validate(context)