Skip to content

[🧹 CHORE]: Priority option transfering #2175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task done
roxblnfk opened this issue May 5, 2025 · 1 comment
Closed
1 task done

[🧹 CHORE]: Priority option transfering #2175

roxblnfk opened this issue May 5, 2025 · 1 comment
Assignees
@rustatian
Labels
C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc..
Milestone
v2025.2

Comments

@roxblnfk
Copy link
Contributor

roxblnfk commented May 5, 2025

No duplicates 🥲.

  • I have searched for a similar issue.

What should be improved or cleaned up?

In Temporal API v1.46, new DTOs related to Priority were added.
In this PR, I exposed the new feature, but RR doesn't proxy the Priority options in ChildWorkflowOptions and ActivityOptions to Temporal.

Looks like we need to build RoadRunner with the new DTOs so that the Priority field is proxied correctly.
@roxblnfk roxblnfk added the C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc.. label May 5, 2025
@roxblnfk roxblnfk mentioned this issue May 5, 2025
Draft
@rustatian rustatian added this to the v2025.2 milestone May 18, 2025
@rustatian rustatian moved this to 🔖 Ready in Jira 😄 May 18, 2025
@rustatian rustatian moved this from 🔖 Ready to 🏗 In progress in Jira 😄 May 19, 2025
@rustatian
Copy link
Member

Since this is already included in the stable RR version, I'll close this issue. Feel free to reopen it if you think we should introduce something different in the scope of that ticket.

@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Jira 😄 May 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rustatian rustatian

Labels
C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc..
Projects
Jira 😄
Status: ✅ Done
Milestone
v2025.2
Development

No branches or pull requests
2 participants
@roxblnfk @rustatian