Skip to content

merge 'yosemite' branch to master? #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
anthrotype opened this issue Dec 12, 2016 · 11 comments
Closed

merge 'yosemite' branch to master? #31

anthrotype opened this issue Dec 12, 2016 · 11 comments

Comments

@anthrotype
Copy link
Member

I noticed that most recent development is happening on a yosemite branch.

DrawBot also seems to require that branch.

Any reasons why this is not merged into master yet?

also, why is it called like that?

Cheers

@typemytype
Copy link
Member

no reason, I guess :)

@anthrotype
Copy link
Member Author

let's merge it then!

@justvanrossum
Copy link
Collaborator

Yes, please, can the yosemite branch be merged into master?

@justvanrossum
Copy link
Collaborator

I see there were commits on both master and yosemite. I'm confused now what is the better branch. Can we please fix this?

@typemytype
Copy link
Member

is there a reason why this is not merged yet?

@justvanrossum
Copy link
Collaborator

@typesupply, please let us know if we can help in any way. I don't have commit rights, and I also don't have a good view on what happened in the main branch after the Yosemite branch was created. But I think it's important we get this done. Also, there are some pull requests that need merging.

@typesupply
Copy link
Member

Sorry. I'm way out of touch with Cocoa development these days. I just added everyone here as collaborators for this project. Let me know if that doesn't give you the access you need.

@justvanrossum
Copy link
Collaborator

Thanks, @typesupply!

It seems the Yosemite branch has no conflicts with the master branch. I made a PR: #43
I suggest we just merge it. @typemytype, what do you say?

@justvanrossum
Copy link
Collaborator

Alright, it's been merged!

@anthrotype, is it indeed wise to just delete the yosemite branch, like github suggests? Seems clean, but I'm not sure how that will affect others.

@anthrotype
Copy link
Member Author

It's safe in the sense that you don't lose the commits as they are now merged in master, but maybe if someone is downloading vanilla from that branch from some setup script or something, this might break.. I'll just leave it there for a while.

@justvanrossum
Copy link
Collaborator

Got it, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants