Replace default value of first parameter in getErrorList() with ''

Replacing the default value with an empty string. Per Juliette's comment
(PHPCSStandards#163 (comment))
there are three reasons why we want to do that:

- The default value has no value in practice. It is an optional argument which is not enforced via the abstract functions, but is passed in all cases, so the default is never used in practice.
- Setting the default value as file 1 also has an assumption implied, while IMO assumptions have no place in a test suite.
- Maintainability - one less thing to have to keep in sync and to guard against typos

Author: rodrigoprimo

src/Standards/Generic/Tests/ControlStructures/InlineControlStructureUnitTest.php

@@ -30,7 +30,7 @@ class InlineControlStructureUnitTest extends AbstractSniffUnitTest
      *
      * @return array<int, int>
      */
-    public function getErrorList($testFile='InlineControlStructureUnitTest.1.inc')
+    public function getErrorList($testFile='')
     {
         switch ($testFile) {
         case 'InlineControlStructureUnitTest.1.inc':

src/Standards/Generic/Tests/PHP/LowerCaseConstantUnitTest.php

@@ -30,7 +30,7 @@ class LowerCaseConstantUnitTest extends AbstractSniffUnitTest
      *
      * @return array<int, int>
      */
-    public function getErrorList($testFile='LowerCaseConstantUnitTest.inc')
+    public function getErrorList($testFile='')
     {
         switch ($testFile) {
         case 'LowerCaseConstantUnitTest.inc':

src/Standards/Generic/Tests/Strings/UnnecessaryStringConcatUnitTest.php

@@ -30,7 +30,7 @@ class UnnecessaryStringConcatUnitTest extends AbstractSniffUnitTest
      *
      * @return array<int, int>
      */
-    public function getErrorList($testFile='UnnecessaryStringConcatUnitTest.inc')
+    public function getErrorList($testFile='')
     {
         switch ($testFile) {
         case 'UnnecessaryStringConcatUnitTest.inc':

src/Standards/Generic/Tests/VersionControl/GitMergeConflictUnitTest.php

@@ -30,7 +30,7 @@ class GitMergeConflictUnitTest extends AbstractSniffUnitTest
      *
      * @return array<int, int>
      */
-    public function getErrorList($testFile='GitMergeConflictUnitTest.1.inc')
+    public function getErrorList($testFile='')
     {
         switch ($testFile) {
         case 'GitMergeConflictUnitTest.1.inc':

src/Standards/Generic/Tests/WhiteSpace/DisallowSpaceIndentUnitTest.php

@@ -49,7 +49,7 @@ public function setCliValues($testFile, $config)
      *
      * @return array<int, int>
      */
-    public function getErrorList($testFile='DisallowSpaceIndentUnitTest.1.inc')
+    public function getErrorList($testFile='')
     {
         switch ($testFile) {
         case 'DisallowSpaceIndentUnitTest.1.inc':

src/Standards/Generic/Tests/WhiteSpace/IncrementDecrementSpacingUnitTest.php

@@ -30,7 +30,7 @@ class IncrementDecrementSpacingUnitTest extends AbstractSniffUnitTest
      *
      * @return array<int, int>
      */
-    public function getErrorList($testFile='IncrementDecrementSpacingUnitTest.inc')
+    public function getErrorList($testFile='')
     {
         $errors = [
             5  => 1,

src/Standards/Generic/Tests/WhiteSpace/ScopeIndentUnitTest.php

@@ -50,7 +50,7 @@ public function setCliValues($testFile, $config)
      *
      * @return array<int, int>
      */
-    public function getErrorList($testFile='ScopeIndentUnitTest.inc')
+    public function getErrorList($testFile='')
     {
         if ($testFile === 'ScopeIndentUnitTest.1.js') {
             return [

src/Standards/MySource/Tests/Debug/FirebugConsoleUnitTest.php

@@ -30,7 +30,7 @@ class FirebugConsoleUnitTest extends AbstractSniffUnitTest
      *
      * @return array<int, int>
      */
-    public function getErrorList($testFile='FirebugConsoleUnitTest.js')
+    public function getErrorList($testFile='')
     {
         if ($testFile !== 'FirebugConsoleUnitTest.js') {
             return [];

src/Standards/MySource/Tests/Objects/AssignThisUnitTest.php

@@ -30,7 +30,7 @@ class AssignThisUnitTest extends AbstractSniffUnitTest
      *
      * @return array<int, int>
      */
-    public function getErrorList($testFile='AssignThisUnitTest.js')
+    public function getErrorList($testFile='')
     {
         if ($testFile !== 'AssignThisUnitTest.js') {
             return [];

src/Standards/MySource/Tests/Strings/JoinStringsUnitTest.php

@@ -30,7 +30,7 @@ class JoinStringsUnitTest extends AbstractSniffUnitTest
      *
      * @return array<int, int>
      */
-    public function getErrorList($testFile='JoinStringsUnitTest.js')
+    public function getErrorList($testFile='')
     {
         if ($testFile !== 'JoinStringsUnitTest.js') {
             return [];

src/Standards/PEAR/Tests/Commenting/FileCommentUnitTest.php

@@ -30,7 +30,7 @@ class FileCommentUnitTest extends AbstractSniffUnitTest
      *
      * @return array<int, int>
      */
-    public function getErrorList($testFile='FileCommentUnitTest.inc')
+    public function getErrorList($testFile='')
     {
         switch ($testFile) {
         case 'FileCommentUnitTest.1.inc':

src/Standards/PEAR/Tests/ControlStructures/MultiLineConditionUnitTest.php

@@ -30,7 +30,7 @@ class MultiLineConditionUnitTest extends AbstractSniffUnitTest
      *
      * @return array<int, int>
      */
-    public function getErrorList($testFile='MultiLineConditionUnitTest.inc')
+    public function getErrorList($testFile='')
     {
         $errors = [
             21  => 1,

src/Standards/PEAR/Tests/Functions/FunctionCallSignatureUnitTest.php

@@ -30,7 +30,7 @@ class FunctionCallSignatureUnitTest extends AbstractSniffUnitTest
      *
      * @return array<int, int>
      */
-    public function getErrorList($testFile='FunctionCallSignatureUnitTest.inc')
+    public function getErrorList($testFile='')
     {
         if ($testFile === 'FunctionCallSignatureUnitTest.js') {
             return [

src/Standards/PEAR/Tests/Functions/FunctionDeclarationUnitTest.php

@@ -30,7 +30,7 @@ class FunctionDeclarationUnitTest extends AbstractSniffUnitTest
      *
      * @return array<int, int>
      */
-    public function getErrorList($testFile='FunctionDeclarationUnitTest.inc')
+    public function getErrorList($testFile='')
     {
         if ($testFile === 'FunctionDeclarationUnitTest.inc') {
             $errors = [

src/Standards/Squiz/Tests/Commenting/DocCommentAlignmentUnitTest.php

@@ -30,7 +30,7 @@ class DocCommentAlignmentUnitTest extends AbstractSniffUnitTest
      *
      * @return array<int, int>
      */
-    public function getErrorList($testFile='DocCommentAlignmentUnitTest.inc')
+    public function getErrorList($testFile='')
     {
         $errors = [
             3  => 1,

src/Standards/Squiz/Tests/Commenting/FileCommentUnitTest.php

@@ -30,7 +30,7 @@ class FileCommentUnitTest extends AbstractSniffUnitTest
      *
      * @return array<int, int>
      */
-    public function getErrorList($testFile='FileCommentUnitTest.inc')
+    public function getErrorList($testFile='')
     {
         switch ($testFile) {
         case 'FileCommentUnitTest.1.inc':

src/Standards/Squiz/Tests/Commenting/InlineCommentUnitTest.php

@@ -30,7 +30,7 @@ class InlineCommentUnitTest extends AbstractSniffUnitTest
      *
      * @return array<int, int>
      */
-    public function getErrorList($testFile='InlineCommentUnitTest.inc')
+    public function getErrorList($testFile='')
     {
         switch ($testFile) {
         case 'InlineCommentUnitTest.inc':

src/Standards/Squiz/Tests/Commenting/LongConditionClosingCommentUnitTest.php

@@ -30,7 +30,7 @@ class LongConditionClosingCommentUnitTest extends AbstractSniffUnitTest
      *
      * @return array<int, int>
      */
-    public function getErrorList($testFile='LongConditionClosingCommentUnitTest.inc')
+    public function getErrorList($testFile='')
     {
         switch ($testFile) {
         case 'LongConditionClosingCommentUnitTest.inc':

src/Standards/Squiz/Tests/Commenting/PostStatementCommentUnitTest.php

@@ -30,7 +30,7 @@ class PostStatementCommentUnitTest extends AbstractSniffUnitTest
      *
      * @return array<int, int>
      */
-    public function getErrorList($testFile='PostStatementCommentUnitTest.inc')
+    public function getErrorList($testFile='')
     {
         switch ($testFile) {
         case 'PostStatementCommentUnitTest.inc':

src/Standards/Squiz/Tests/ControlStructures/ControlSignatureUnitTest.php

@@ -30,7 +30,7 @@ class ControlSignatureUnitTest extends AbstractSniffUnitTest
      *
      * @return array<int, int>
      */
-    public function getErrorList($testFile='ControlSignatureUnitTest.inc')
+    public function getErrorList($testFile='')
     {
         $errors = [
             7   => 1,

src/Standards/Squiz/Tests/ControlStructures/ForLoopDeclarationUnitTest.php

@@ -30,7 +30,7 @@ class ForLoopDeclarationUnitTest extends AbstractSniffUnitTest
      *
      * @return array<int, int>
      */
-    public function getErrorList($testFile='ForLoopDeclarationUnitTest.inc')
+    public function getErrorList($testFile='')
     {
         switch ($testFile) {
         case 'ForLoopDeclarationUnitTest.inc':

src/Standards/Squiz/Tests/ControlStructures/SwitchDeclarationUnitTest.php

@@ -30,7 +30,7 @@ class SwitchDeclarationUnitTest extends AbstractSniffUnitTest
      *
      * @return array<int, int>
      */
-    public function getErrorList($testFile='SwitchDeclarationUnitTest.inc')
+    public function getErrorList($testFile='')
     {
         switch ($testFile) {
         case 'SwitchDeclarationUnitTest.inc':

src/Standards/Squiz/Tests/Formatting/OperatorBracketUnitTest.php

@@ -30,7 +30,7 @@ class OperatorBracketUnitTest extends AbstractSniffUnitTest
      *
      * @return array<int, int>
      */
-    public function getErrorList($testFile='OperatorBracketUnitTest.inc')
+    public function getErrorList($testFile='')
     {
         switch ($testFile) {
         case 'OperatorBracketUnitTest.inc':

src/Standards/Squiz/Tests/Functions/MultiLineFunctionDeclarationUnitTest.php

@@ -30,7 +30,7 @@ class MultiLineFunctionDeclarationUnitTest extends AbstractSniffUnitTest
      *
      * @return array<int, int>
      */
-    public function getErrorList($testFile='MultiLineFunctionDeclarationUnitTest.inc')
+    public function getErrorList($testFile='')
     {
         if ($testFile === 'MultiLineFunctionDeclarationUnitTest.inc') {
             $errors = [

src/Standards/Squiz/Tests/Objects/DisallowObjectStringIndexUnitTest.php

@@ -30,7 +30,7 @@ class DisallowObjectStringIndexUnitTest extends AbstractSniffUnitTest
      *
      * @return array<int, int>
      */
-    public function getErrorList($testFile='DisallowObjectStringIndexUnitTest.js')
+    public function getErrorList($testFile='')
     {
         if ($testFile !== 'DisallowObjectStringIndexUnitTest.js') {
             return [];

src/Standards/Squiz/Tests/Operators/ComparisonOperatorUsageUnitTest.php

@@ -30,7 +30,7 @@ class ComparisonOperatorUsageUnitTest extends AbstractSniffUnitTest
      *
      * @return array<int, int>
      */
-    public function getErrorList($testFile='ComparisonOperatorUsageUnitTest.inc')
+    public function getErrorList($testFile='')
     {
         switch ($testFile) {
         case 'ComparisonOperatorUsageUnitTest.inc':

src/Standards/Squiz/Tests/PHP/DisallowInlineIfUnitTest.php

@@ -30,7 +30,7 @@ class DisallowInlineIfUnitTest extends AbstractSniffUnitTest
      *
      * @return array<int, int>
      */
-    public function getErrorList($testFile='DisallowInlineIfUnitTest.inc')
+    public function getErrorList($testFile='')
     {
         switch ($testFile) {
         case 'DisallowInlineIfUnitTest.inc':

src/Standards/Squiz/Tests/PHP/DisallowSizeFunctionsInLoopsUnitTest.php

@@ -30,7 +30,7 @@ class DisallowSizeFunctionsInLoopsUnitTest extends AbstractSniffUnitTest
      *
      * @return array<int, int>
      */
-    public function getErrorList($testFile='DisallowSizeFunctionsInLoopsUnitTest.inc')
+    public function getErrorList($testFile='')
     {
         switch ($testFile) {
         case 'DisallowSizeFunctionsInLoopsUnitTest.inc':

src/Standards/Squiz/Tests/WhiteSpace/ControlStructureSpacingUnitTest.php

@@ -30,7 +30,7 @@ class ControlStructureSpacingUnitTest extends AbstractSniffUnitTest
      *
      * @return array<int, int>
      */
-    public function getErrorList($testFile='ControlStructureSpacingUnitTest.inc')
+    public function getErrorList($testFile='')
     {
         switch ($testFile) {
         case 'ControlStructureSpacingUnitTest.inc':

src/Standards/Squiz/Tests/WhiteSpace/FunctionClosingBraceSpaceUnitTest.php

@@ -30,7 +30,7 @@ class FunctionClosingBraceSpaceUnitTest extends AbstractSniffUnitTest
      *
      * @return array<int, int>
      */
-    public function getErrorList($testFile='FunctionClosingBraceSpaceUnitTest.inc')
+    public function getErrorList($testFile='')
     {
         switch ($testFile) {
         case 'FunctionClosingBraceSpaceUnitTest.inc':

src/Standards/Squiz/Tests/WhiteSpace/FunctionOpeningBraceSpaceUnitTest.php

@@ -30,7 +30,7 @@ class FunctionOpeningBraceSpaceUnitTest extends AbstractSniffUnitTest
      *
      * @return array<int, int>
      */
-    public function getErrorList($testFile='FunctionOpeningBraceSpaceUnitTest.inc')
+    public function getErrorList($testFile='')
     {
         switch ($testFile) {
         case 'FunctionOpeningBraceSpaceUnitTest.inc':

src/Standards/Squiz/Tests/WhiteSpace/OperatorSpacingUnitTest.php

@@ -30,7 +30,7 @@ class OperatorSpacingUnitTest extends AbstractSniffUnitTest
      *
      * @return array<int, int>
      */
-    public function getErrorList($testFile='OperatorSpacingUnitTest.inc')
+    public function getErrorList($testFile='')
     {
         switch ($testFile) {
         case 'OperatorSpacingUnitTest.inc':

src/Standards/Squiz/Tests/WhiteSpace/SemicolonSpacingUnitTest.php

@@ -30,7 +30,7 @@ class SemicolonSpacingUnitTest extends AbstractSniffUnitTest
      *
      * @return array<int, int>
      */
-    public function getErrorList($testFile='SemicolonSpacingUnitTest.inc')
+    public function getErrorList($testFile='')
     {
         switch ($testFile) {
         case 'SemicolonSpacingUnitTest.inc':

src/Standards/Squiz/Tests/WhiteSpace/SuperfluousWhitespaceUnitTest.php

@@ -30,7 +30,7 @@ class SuperfluousWhitespaceUnitTest extends AbstractSniffUnitTest
      *
      * @return array<int, int>
      */
-    public function getErrorList($testFile='SuperfluousWhitespaceUnitTest.inc')
+    public function getErrorList($testFile='')
     {
         switch ($testFile) {
         case 'SuperfluousWhitespaceUnitTest.1.inc':