Skip to content

Commit bafc7d3

Browse files
authored
More correct error message, issue #328 (#334)
* Addressing issue #328, cleaned up the error message, to be more correct, but not more useful :-/ * Preparing release
1 parent df486cb commit bafc7d3

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44

55
- Docker based image updated for Python 3.14.3 slim trixie via PR [#325](https://github.com/rojopolis/spellcheck-github-actions/pull/325) from Dependabot.
66

7+
- Cleaned up the error messaging, to address issue [#328](https://github.com/rojopolis/spellcheck-github-actions/issues/328) from @akohout-hai, the error message is now more correct, but not improved in general
8+
79
## 0.59.0, 2026-03-02, feature release, update recommended
810

911
- Improvements have been added to the docker entrypoint, based on a PR from @akohout-hai which fixes an issue with handling of spaces in files names and directories, see PR [#322](https://github.com/rojopolis/spellcheck-github-actions/pull/322) for details. This is his first contribution to the project and I want to thank him for his contribution, which is highly appreciated.

entrypoint.sh

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -177,13 +177,9 @@ fi
177177
echo "----------------------------------------------------------------"
178178

179179
if [ -n "$GITHUB_ACTIONS" ]; then
180-
test "$EXITCODE" -gt 1 && echo "::error title=Spelling check::Spelling check action failed, please check diagnostics";
181-
182-
test "$EXITCODE" -eq 1 && echo "::error title=Spelling errors::Files in repository contain spelling errors";
180+
test "$EXITCODE" -gt 0 && echo "::error title=Error::Files in repository contain spelling errors or or spelling check action failed, please check diagnostics";
183181
else
184-
test "$EXITCODE" -gt 1 && echo "Spelling check action failed, please check diagnostics";
185-
186-
test "$EXITCODE" -eq 1 && echo "Files in repository contain spelling errors";
182+
test "$EXITCODE" -gt 0 && echo "Files in repository contain spelling errors or spelling check action failed, please check diagnostics";
187183
fi
188184

189185
exit "$EXITCODE"

0 commit comments

Comments
 (0)