fix(typescript): Allow for using compilerOptions.moduleResolution (#1453)

* fix(typescript): Add test for setting moduleResolution

This adds a test case for resolving types with node ESM `exports` feature
and `compilerOptions.moduleResolution` option configured.

Signed-off-by: Ferdinand Thiessen <[email protected]>

* fix(typescript): Allow for using `compilerOptions.moduleResolution`

Signed-off-by: Ferdinand Thiessen <[email protected]>

---------

Signed-off-by: Ferdinand Thiessen <[email protected]>

Author: susnux

packages/typescript/src/options/tsconfig.ts

@@ -105,6 +105,7 @@ function containsEnumOptions(
  */
 function setModuleResolutionKind(parsedConfig: ParsedCommandLine): ParsedCommandLine {
   const moduleKind = parsedConfig.options.module;
+  // Fallback if `parsedConfig.options.moduleResolution` is not set
   const moduleResolution =
     moduleKind === ModuleKind.Node16
       ? ModuleResolutionKind.Node16
@@ -115,8 +116,8 @@ function setModuleResolutionKind(parsedConfig: ParsedCommandLine): ParsedCommand
   return {
     ...parsedConfig,
     options: {
-      ...parsedConfig.options,
-      moduleResolution
+      moduleResolution,
+      ...parsedConfig.options
     }
   };
 }

packages/typescript/test/fixtures/nodenext-module/index.ts

@@ -0,0 +1,4 @@
+import foo from 'foo';
+
+const bar: string = foo;
+console.log(bar);

…-resolution/node_modules/foo/index.d.cts …next-module/node_modules/foo/index.d.ctspackages/typescript/test/fixtures/nodenext-resolution/node_modules/foo/index.d.cts renamed to packages/typescript/test/fixtures/nodenext-module/node_modules/foo/index.d.cts packages/typescript/test/fixtures/nodenext-resolution/node_modules/foo/index.d.cts renamed to packages/typescript/test/fixtures/nodenext-module/node_modules/foo/index.d.cts

@@ -0,0 +1,3 @@
+{
+  "type": "module"
+}

…t-resolution/node_modules/foo/index.d.ts …enext-module/node_modules/foo/index.d.tspackages/typescript/test/fixtures/nodenext-resolution/node_modules/foo/index.d.ts renamed to packages/typescript/test/fixtures/nodenext-module/node_modules/foo/index.d.ts packages/typescript/test/fixtures/nodenext-resolution/node_modules/foo/index.d.ts renamed to packages/typescript/test/fixtures/nodenext-module/node_modules/foo/index.d.ts

@@ -0,0 +1,5 @@
+{
+  "compilerOptions": {
+    "module": "nodenext"
+  }
+}