Skip to content

Commit 75ac75e

Browse files
authored
Expected bytes error message and imports cleanup (#400)
* Format expected bytes error with base64 as in ron * Reformat imports to be consistent
1 parent 4089034 commit 75ac75e

24 files changed

Lines changed: 65 additions & 45 deletions

examples/decode.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
#![allow(dead_code)]
22

3+
use std::collections::HashMap;
4+
35
use ron::de::from_str;
46
use serde::Deserialize;
5-
use std::collections::HashMap;
67

78
#[derive(Debug, Deserialize)]
89
struct Config {

examples/decode_file.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
#![allow(dead_code)]
22

3+
use std::{collections::HashMap, fs::File};
4+
35
use ron::de::from_reader;
46
use serde::Deserialize;
5-
use std::{collections::HashMap, fs::File};
67

78
#[derive(Debug, Deserialize)]
89
struct Config {

examples/encode.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
1+
use std::{collections::HashMap, iter::FromIterator};
2+
13
use ron::ser::{to_string_pretty, PrettyConfig};
24
use serde::Serialize;
3-
use std::{collections::HashMap, iter::FromIterator};
45

56
#[derive(Serialize)]
67
struct Config {

rustfmt.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
hard_tabs = false
22
use_field_init_shorthand = true
33
use_try_shorthand = true
4-
edition = "2018"
4+
edition = "2021"

src/de/mod.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
/// Deserialization module.
2-
pub use crate::error::{Error, Position, SpannedError};
2+
use std::{borrow::Cow, io, str};
33

44
use serde::de::{self, DeserializeSeed, Deserializer as SerdeError, Visitor};
5-
use std::{borrow::Cow, io, str};
65

76
use self::{id::IdDeserializer, tag::TagDeserializer};
7+
pub use crate::error::{Error, Position, SpannedError};
88
use crate::{
99
error::{Result, SpannedResult},
1010
extensions::Extensions,

src/de/tests.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,9 +162,10 @@ fn err<T>(kind: Error, line: usize, col: usize) -> SpannedResult<T> {
162162

163163
#[test]
164164
fn test_err_wrong_value() {
165-
use self::Error::*;
166165
use std::collections::HashMap;
167166

167+
use self::Error::*;
168+
168169
assert_eq!(from_str::<f32>("'c'"), err(ExpectedFloat, 1, 1));
169170
assert_eq!(from_str::<String>("'c'"), err(ExpectedString, 1, 1));
170171
assert_eq!(from_str::<HashMap<u32, u32>>("'c'"), err(ExpectedMap, 1, 1));

src/de/value.rs

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,10 @@ use serde::{
55
Deserialize, Deserializer,
66
};
77

8-
use crate::error::SpannedResult;
9-
use crate::value::{Map, Number, Value};
8+
use crate::{
9+
error::SpannedResult,
10+
value::{Map, Number, Value},
11+
};
1012

1113
impl std::str::FromStr for Value {
1214
type Err = crate::error::SpannedError;
@@ -181,9 +183,10 @@ impl<'de> Visitor<'de> for ValueVisitor {
181183

182184
#[cfg(test)]
183185
mod tests {
184-
use super::*;
185186
use std::str::FromStr;
186187

188+
use super::*;
189+
187190
fn eval(s: &str) -> Value {
188191
s.parse().expect("Failed to parse")
189192
}

src/error.rs

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
1-
use serde::{de, ser};
21
use std::{error::Error as StdError, fmt, io, str::Utf8Error, string::FromUtf8Error};
32

3+
use serde::{de, ser};
4+
45
/// This type represents all possible errors that can occur when
56
/// serializing or deserializing RON data.
67
#[derive(Clone, Debug, PartialEq, Eq)]
@@ -276,15 +277,9 @@ impl de::Error for Error {
276277
Float(n) => write!(f, "the floating point number `{}`", n),
277278
Char(c) => write!(f, "the UTF-8 character `{}`", c),
278279
Str(s) => write!(f, "the string {:?}", s),
279-
Bytes(b) => {
280-
f.write_str("the bytes b\"")?;
281-
282-
for b in b {
283-
write!(f, "\\x{:02x}", b)?;
284-
}
285-
286-
f.write_str("\"")
287-
}
280+
Bytes(b) => write!(f, "the bytes \"{}\"", {
281+
base64::display::Base64Display::with_config(b, base64::STANDARD)
282+
}),
288283
Unit => write!(f, "a unit value"),
289284
Option => write!(f, "an optional value"),
290285
NewtypeStruct => write!(f, "a newtype struct"),

src/options.rs

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,12 @@ use std::io;
44

55
use serde::{de, ser, Deserialize, Serialize};
66

7-
use crate::de::Deserializer;
8-
use crate::error::{Result, SpannedResult};
9-
use crate::extensions::Extensions;
10-
use crate::ser::{PrettyConfig, Serializer};
7+
use crate::{
8+
de::Deserializer,
9+
error::{Result, SpannedResult},
10+
extensions::Extensions,
11+
ser::{PrettyConfig, Serializer},
12+
};
1113

1214
/// Roundtrip serde options.
1315
///

src/ser/mod.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
1-
use serde::{ser, Deserialize, Serialize};
21
use std::io;
32

3+
use serde::{ser, Deserialize, Serialize};
4+
45
use crate::{
56
error::{Error, Result},
67
extensions::Extensions,

0 commit comments

Comments
 (0)