fix: remove http-errors dependency

We're now using our own simple error class to avoid including an
unnecessary dependency.

Author: rowanmanning

lib/allow-methods.js

@@ -1,6 +1,17 @@
 'use strict';
 
-const httpError = require('http-errors');
+class MethodNotAllowedError extends Error {
+
+	/** @type {string} */
+	name = 'MethodNotAllowedError';
+
+	/** @type {number} */
+	status = 405;
+
+	/** @type {number} */
+	statusCode = 405;
+
+}
 
 /**
  * Create an Express middleware function which errors if an HTTP method is not allowed.
@@ -18,7 +29,7 @@ function allowMethods(methods = [], message = 'Method Not Allowed') {
 	return (request, response, next) => {
 		if (!normalizedMethods.includes(request.method.toUpperCase())) {
 			response.header('Allow', normalizedMethods.join(', '));
-			return next(httpError(405, message));
+			return next(new MethodNotAllowedError(message));
 		}
 		next();
 	};

package-lock.json

@@ -36,9 +36,6 @@
     "project:fix": "npx --yes @rowanmanning/validate-project@2 --type git node-library --fix",
     "prepare": "husky install"
   },
-  "dependencies": {
-    "http-errors": "^2.0.0"
-  },
   "devDependencies": {
     "@commitlint/cli": "^17.0.0",
     "@commitlint/config-conventional": "^17.0.0",

package.json

@@ -5,13 +5,8 @@ const td = require('testdouble');
 
 describe('lib/allow-methods', () => {
 	let allowMethods;
-	let error405;
-	let httpError;
 
 	beforeEach(() => {
-		httpError = td.replace('http-errors', td.func());
-		error405 = {status: 405};
-		td.when(httpError(), {ignoreExtraArgs: true}).thenReturn(error405);
 		allowMethods = require('../../../lib/allow-methods');
 	});
 
@@ -71,17 +66,21 @@ describe('lib/allow-methods', () => {
 				it('calls back with a 405 error', done => {
 					request.method = 'BAZ';
 					allowMethods(['FOO', 'bar'])(request, response, error => {
-						assert.strictEqual(error, error405);
-						td.verify(httpError(405, 'Method Not Allowed'), {times: 1});
+						assert.ok(error instanceof Error);
+						assert.strictEqual(error.status, 405);
+						assert.strictEqual(error.statusCode, 405);
+						assert.strictEqual(error.message, 'Method Not Allowed');
 						done();
 					});
 				});
 
 				it('calls back with a 405 error with a custom message if specified', done => {
 					request.method = 'BAZ';
 					allowMethods(['FOO', 'bar'], 'mock message')(request, response, error => {
-						assert.strictEqual(error, error405);
-						td.verify(httpError(405, 'mock message'), {times: 1});
+						assert.ok(error instanceof Error);
+						assert.strictEqual(error.status, 405);
+						assert.strictEqual(error.statusCode, 405);
+						assert.strictEqual(error.message, 'mock message');
 						done();
 					});
 				});
@@ -101,8 +100,10 @@ describe('lib/allow-methods', () => {
 				it('calls back with a 405 error', done => {
 					request.method = 'FOO';
 					allowMethods({})(request, response, error => {
-						assert.strictEqual(error, error405);
-						td.verify(httpError(405, 'Method Not Allowed'), {times: 1});
+						assert.ok(error instanceof Error);
+						assert.strictEqual(error.status, 405);
+						assert.strictEqual(error.statusCode, 405);
+						assert.strictEqual(error.message, 'Method Not Allowed');
 						done();
 					});
 				});