Skip to content

CVE-2019-11840 worth investigating? #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tsatke opened this issue Aug 28, 2019 · 6 comments · Fixed by #183
Closed

CVE-2019-11840 worth investigating? #182

tsatke opened this issue Aug 28, 2019 · 6 comments · Fixed by #183

Comments

@tsatke
Copy link
Contributor

tsatke commented Aug 28, 2019

https://ossindex.sonatype.org/vuln/5121f5ff-9831-44a6-af2e-24f7301d1df7

Detected by DepShield in gojisvm/gojis#61

Maybe this isn't worth investigating or incorrect in this case, but I would like some feedback on this :)

@rs
Copy link
Owner

rs commented Aug 28, 2019

What part of zerolog would be affected?

@tsatke
Copy link
Contributor Author

tsatke commented Aug 28, 2019

There is a fix for this (golang/go#30965), but this fix was merged on March 21st, you are using a commit from March 8th.

Maybe updating your x/tools dependency to a newer version fixes this?

@tsatke
Copy link
Contributor Author

tsatke commented Aug 28, 2019

I am not familiar with the library in depth, but I'm thinking wherever you are using the x/tools

@rs
Copy link
Owner

rs commented Aug 28, 2019

It’s used by the linter tool (should prob be excluded from go.mod, and it’s not using the crypto package).

@tsatke
Copy link
Contributor Author

tsatke commented Aug 28, 2019

Forked it and tried it, tools is on latest commit actually (20190425)...
But I noticed you didn't commit a go.sum file, you should probably do that.

Alright, thanks for the feedback, feel free to close this issue, thanks for the incredibly fast response!

@tsatke
Copy link
Contributor Author

tsatke commented Aug 28, 2019

Actually there is a new version... Opened a PR just now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants