Adding DSL test

Author: nagarev

rskj-core/src/test/java/co/rsk/rpc/modules/eth/EthModuleDSLTest.java

@@ -24,6 +24,7 @@
 import co.rsk.test.dsl.WorldDslProcessor;
 import co.rsk.util.HexUtils;
 import org.ethereum.core.Account;
+import org.ethereum.core.Block;
 import org.ethereum.core.Transaction;
 import org.ethereum.core.TransactionReceipt;
 import org.ethereum.rpc.CallArguments;
@@ -91,7 +92,7 @@ void testCall_getRevertReason() throws FileNotFoundException, DslProcessorExcept
     }
 
     @Test
-    void testCall_StateOverride_stateIsOverride() throws DslProcessorException, FileNotFoundException {
+    void testCall_StateOverride_stateIsOverridden() throws DslProcessorException, FileNotFoundException {
         // When
         World world = new World();
         // given a deployed contract with stored state = 10
@@ -135,7 +136,7 @@ void testCall_StateOverride_stateIsOverride() throws DslProcessorException, File
      * }
      */
     @Test
-    void testCall_StateOverride_codeOverride() throws DslProcessorException, FileNotFoundException {
+    void testCall_StateOverride_codeIsOverridden() throws DslProcessorException, FileNotFoundException {
         // Given
         // This is the runtime bytecode of the contract above to override the original contract
         String runtimeByteCode = "0x6103e760005260206000f3";
@@ -169,7 +170,7 @@ void testCall_StateOverride_codeOverride() throws DslProcessorException, FileNot
     }
 
     @Test
-    void testCall_StateOverride_balanceOverride()throws DslProcessorException, FileNotFoundException {
+    void testCall_StateOverride_balanceIsOverridden()throws DslProcessorException, FileNotFoundException {
         // Given
         long defaultBalance = 30000L;
         World world = new World();
@@ -203,6 +204,69 @@ void testCall_StateOverride_balanceOverride()throws DslProcessorException, FileN
         assertEquals(defaultBalance, HexUtils.jsonHexToInt(result2));
     }
 
+    @Test
+    void testCall_StateOverride_precompiledContractIsMoved() throws DslProcessorException, FileNotFoundException {
+
+        // Given
+
+        String falseInHex = "0x0000000000000000000000000000000000000000000000000000000000000000";
+        String trueInHex = "0x0000000000000000000000000000000000000000000000000000000000000001";
+
+        // Test Setup
+
+        DslParser parser = DslParser.fromResource("dsl/eth_module/test_state_override_move_precompiled.txt");
+        World world = new World();
+        WorldDslProcessor processor = new WorldDslProcessor(world);
+        processor.processCommands(parser);
+
+        Account acc = world.getAccountByName("acc1");
+        RskAddress identityPrecompiledAddress = new RskAddress("0x0000000000000000000000000000000000000004");
+        RskAddress movePrecompiledTo = new RskAddress("0x0000000000000000000000000000000000000001");
+
+        // Test Steps
+
+        // 0. Check that DatacopyCaller contract was deployed correctly
+        Block block01 = world.getBlockByName("b01");
+        Assertions.assertNotNull(block01);
+        Assertions.assertEquals(1, block01.getTransactionsList().size());
+
+        String contractAddress = world.getTransactionByName("tx01").getContractAddress().toHexString();
+
+        // 1. Check that checkOriginalDatacopyWorksAsExpected (0xb7deb48b) is executed correctly
+
+        EthModule eth = EthModuleTestUtils.buildBasicEthModule(world);
+
+        CallArguments args = new CallArguments();
+        args.setFrom(acc.getAddress().toHexString());
+        args.setTo("0x" + contractAddress);
+        args.setData("0xb7deb48b"); // Call checkOriginalDatacopyWorksAsExpected() function
+        BlockIdentifierParam blockIdentifierParam = new BlockIdentifierParam("latest");
+        CallArgumentsParam callArgumentsParam = TransactionFactoryHelper.toCallArgumentsParam(args);
+
+        String result = eth.call(callArgumentsParam, blockIdentifierParam);
+        assertEquals(trueInHex, result);
+
+        // 2. Check that checkOverriddenDatacopyWorksAsExpected (0x1cf61a8b) returns "false" before overriding
+
+        CallArguments args2 = new CallArguments();
+        args2.setFrom(acc.getAddress().toHexString());
+        args2.setTo("0x" + contractAddress);
+        args2.setData("0x1cf61a8b"); // Call checkOverriddenDatacopyWorksAsExpected() function
+        CallArgumentsParam callArgumentsParam2 = TransactionFactoryHelper.toCallArgumentsParam(args2);
+
+        String result2 = eth.call(callArgumentsParam2, blockIdentifierParam);
+        assertEquals(falseInHex, result2);
+
+        // 3. Check that checkOverriddenDatacopyWorksAsExpected (0x1cf61a8b) returns "true" after overriding
+
+        AccountOverride accountOverride = new AccountOverride(identityPrecompiledAddress);
+        accountOverride.setMovePrecompileToAddress(movePrecompiledTo);
+
+        String result3 = eth.call(callArgumentsParam2, blockIdentifierParam, List.of(accountOverride));
+        assertEquals(trueInHex, result3);
+
+    }
+
     private String deployContractAndGetAddressFromDsl(String dslContractPath, World world) throws DslProcessorException, FileNotFoundException{
         DslParser parser = DslParser.fromResource(dslContractPath);
         WorldDslProcessor processor = new WorldDslProcessor(world);

rskj-core/src/test/resources/dsl/eth_module/test_state_override_move_precompiled.txt

@@ -0,0 +1,100 @@
+comment
+
+Simple Datacopy caller contract
+
+checkOriginalDatacopyWorksAsExpected calls datacopy (The Identity Precompiled Contract) on its original address
+- Returns true if data copy was executed correctly
+- Returns false otherwise (THIS SHOULD NEVER HAPPEN)
+
+checkOverriddenDatacopyWorksAsExpected calls datacopy on the address 0x01 (where ecrecover is originally located)
+if movePrecompiledTo was excecuted previously for the identity contract on 0x01
+- Return true if data copy was excecuted correctly
+- Return false otherwise (THIS SHOULD NEVER HAPPEN EITHER, as movePrecompiledTo should work correctly)
+
+// SPDX-License-Identifier: UNLICENSED
+pragma solidity ^0.8.0;
+
+contract DatacopyCaller {
+    constructor(){}
+
+    // Check datacopy (Identity precompiled contract) in its original address (0x04).
+    function checkOriginalDatacopyWorksAsExpected() external returns (bool ok) {
+        bytes memory data = "input";
+        bytes memory result = new bytes(data.length); // Allocate memory for the result
+
+        assembly {
+            // Get the length of the input data
+            let len := mload(data)
+
+            // Call the precompiled contract at address 0x04
+            // Arguments:
+            // 1. gas: gas available for the call
+            // 2. 0x04: address of the Data Copy precompile
+            // 3. 0: value (ether) to send (none for Data Copy)
+            // 4. add(data, 0x20): memory address of the input data (offset by 0x20 for length field)
+            // 5. len: length of the input data
+            // 6. add(result, 0x20): memory address to store the output (offset by 0x20 for length field)
+            // 7. len: expected length of the output data
+            if iszero(call(gas(), 0x04, 0, add(data, 0x20), len, add(result, 0x20), len)) {
+                // Revert if the call fails
+                invalid()
+            }
+        }
+
+        // Using keccak256 to be able to compare "bytes memory" variables
+        return keccak256(result) == keccak256(data);
+    }
+
+    // Check datacopy (Identity precompiled contract) in the overridden address (0x01).
+    // This function returns true only after the Identity contract was copied to 0x01
+    // Will return false otherwise.
+    function checkOverriddenDatacopyWorksAsExpected() external returns (bool ok) {
+        bytes memory data = "input";
+        bytes memory result = new bytes(data.length); // Allocate memory for the result
+
+        assembly {
+            // Get the length of the input data
+            let len := mload(data)
+
+            // Call the precompiled contract at address 0x04
+            // Arguments:
+            // 1. gas: gas available for the call
+            // 2. 0x01: address of the Data Copy precompile (overridden)
+            // 3. 0: value (ether) to send (none for Data Copy)
+            // 4. add(data, 0x20): memory address of the input data (offset by 0x20 for length field)
+            // 5. len: length of the input data
+            // 6. add(result, 0x20): memory address to store the output (offset by 0x20 for length field)
+            // 7. len: expected length of the output data
+            if iszero(call(gas(), 0x01, 0, add(data, 0x20), len, add(result, 0x20), len)) {
+                // Revert if the call fails
+                invalid()
+            }
+        }
+
+        return keccak256(result) == keccak256(data);
+    }
+
+}
+
+end
+
+account_new acc1 20000000
+
+transaction_build tx01
+    sender acc1
+    receiverAddress 00
+    value 0
+    data 6080604052348015600e575f5ffd5b506102808061001c5f395ff3fe608060405234801561000f575f5ffd5b5060043610610034575f3560e01c80631cf61a8b14610038578063b7deb48b14610056575b5f5ffd5b610040610074565b60405161004d9190610204565b60405180910390f35b61005e61012f565b60405161006b9190610204565b60405180910390f35b5f5f6040518060400160405280600581526020017f696e70757400000000000000000000000000000000000000000000000000000081525090505f815167ffffffffffffffff8111156100ca576100c961021d565b5b6040519080825280601f01601f1916602001820160405280156100fc5781602001600182028036833780820191505090505b5090508151806020830182602086015f60015af161011657fe5b5081805190602001208180519060200120149250505090565b5f5f6040518060400160405280600581526020017f696e70757400000000000000000000000000000000000000000000000000000081525090505f815167ffffffffffffffff8111156101855761018461021d565b5b6040519080825280601f01601f1916602001820160405280156101b75781602001600182028036833780820191505090505b5090508151806020830182602086015f60045af16101d157fe5b5081805190602001208180519060200120149250505090565b5f8115159050919050565b6101fe816101ea565b82525050565b5f6020820190506102175f8301846101f5565b92915050565b7f4e487b71000000000000000000000000000000000000000000000000000000005f52604160045260245ffdfea26469706673582212202ece15a537aa6a01c75693f02004e83bd4f90505ed9146202bc64e3a11fed46164736f6c634300081c0033
+    gas 750000
+    build
+
+block_build b01
+    parent g00
+    transactions tx01
+    gasLimit 7500000
+    build
+
+block_connect b01
+
+# Assert best block
+assert_best b01