Skip to content

rsocket-*@0.0.11 is missing build/* -- only has package.json #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sandersn opened this issue Oct 14, 2019 · 5 comments
Closed

rsocket-*@0.0.11 is missing build/* -- only has package.json #58

sandersn opened this issue Oct 14, 2019 · 5 comments

Comments

@sandersn
Copy link

sandersn commented Oct 14, 2019

Looks like an incorrect publish.

Discovered on Definitely Typed, which has types for rsocket-(tcp|websocket)-(client|server).
Here's the failure from the overnight run: https://dev.azure.com/definitelytyped/DefinitelyTyped/_build/results?buildId=18518

If this is intentional, I'll remove those type packages from Definitely Typed.

@OlegDokuka
Copy link
Member

Hi @sandersn! Not sure the failure is intentional but type definitions has done my community and seem to be a little incorrect in terms of following the original API. I'm going to take a loot at that thing later this week if it is not that urgent

@sandersn
Copy link
Author

Well, in this case the types are fine -- 0.0.11 itself is a bad publish. There's no source code shipped with the package! So users who npm install rsocket-tcp-client, for example, will get a broken package.

@stevegury
Copy link
Member

@sandersn Sorry for the trouble, could you try again with 0.0.16?

@sandersn
Copy link
Author

Yep, looks like the latest checks for @types/rsocket-* all passed. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants