Commit 8bc3f80
committed
Apply gem version constraints for older Rubies
Sprockets 4.0 depend on Ruby >= 2.5 https://rubygems.org/gems/sprockets/versions/4.0.0
This results in build failures
(https://travis-ci.org/github/rspec/rspec-rails/jobs/713253057):
Installing sprockets 4.0.2
Gem::RuntimeRequirementNotMetError: sprockets requires Ruby version >= 2.5.0.
The current ruby version is 2.4.10.364.
Surprisingly, Ruby 2.3.8 and Ruby 2.2.10 builds don't fail, and install
sprockets 3.7.2.
Other failures follow:
Gem::RuntimeRequirementNotMetError: capybara requires Ruby version >= 2.5.0. The current ruby version is 2.4.10.364.
An error occurred while installing capybara (3.33.0), and Bundler cannot continue.
Make sure that `gem install capybara -v '3.33.0' --source 'https://rubygems.org/'` succeeds before bundling.
Gem::RuntimeRequirementNotMetError: childprocess requires Ruby version >= 2.3.0. The current ruby version is 2.2.0.
An error occurred while installing childprocess (3.0.0), and Bundler cannot continue.
Make sure that `gem install childprocess -v '3.0.0' --source
Gem::RuntimeRequirementNotMetError: nio4r requires Ruby version >= 2.3. The current ruby version is 2.2.0.
An error occurred while installing nio4r (2.5.2), and Bundler cannot continue.
Make sure that `gem install nio4r -v '2.5.2' --source 'https://rubygems.org/'` succeeds before bundling.
Gem::RuntimeRequirementNotMetError: rack requires Ruby version >= 2.3.0. The current ruby version is 2.2.0.
An error occurred while installing rack (2.2.3), and Bundler cannot continue.
Make sure that `gem install rack -v '2.2.3' --source 'https://rubygems.org/'` succeeds before bundling.
Gem::RuntimeRequirementNotMetError: i18n requires Ruby version >= 2.3.0. The current ruby version is 2.2.0.
An error occurred while installing i18n (1.8.5), and Bundler cannot continue.
Make sure that `gem install i18n -v '1.8.5' --source 'https://rubygems.org/'` succeeds before bundling.
We always generate example apps for >= 5.0.0 (4.2 is not in the matrix),
hence the removal of a condition.
This is a forgotten forward-port from https://github.com/rspec/rspec-rails/pull/2360/files#diff-8c3955be04b733dbd31e54e50844fb84R311 parent 60dc9c4 commit 8bc3f80
File tree
3 files changed
+18
-2
lines changed- example_app_generator
3 files changed
+18
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
52 | | - | |
| 52 | + | |
53 | 53 | | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
54 | 58 | | |
55 | 59 | | |
56 | 60 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| 21 | + | |
21 | 22 | | |
22 | 23 | | |
23 | 24 | | |
| |||
28 | 29 | | |
29 | 30 | | |
30 | 31 | | |
31 | | - | |
| 32 | + | |
32 | 33 | | |
33 | 34 | | |
34 | 35 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
38 | 47 | | |
39 | 48 | | |
40 | 49 | | |
41 | 50 | | |
42 | 51 | | |
| 52 | + | |
| 53 | + | |
43 | 54 | | |
44 | 55 | | |
45 | 56 | | |
| |||
0 commit comments