Skip to content

Commit a34dea7

Browse files
committed
experiment! define name to work around TaggedLogging
RSpec.current_example.metadata[:name] evaluates to `nil` by the time this is called.
1 parent d372749 commit a34dea7

File tree

2 files changed

+11
-5
lines changed

2 files changed

+11
-5
lines changed

lib/rspec/rails/adapters.rb

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -181,5 +181,15 @@ def assertion_delegator
181181
#
182182
# @private
183183
TestUnitAssertionAdapter = MinitestAssertionAdapter
184+
185+
# @private
186+
module TaggedLoggingAdapter
187+
require 'active_support/testing/tagged_logging'
188+
include ActiveSupport::Testing::TaggedLogging
189+
190+
# Just a stub as TaggedLogging is calling `name`
191+
def name
192+
end
193+
end
184194
end
185195
end

lib/rspec/rails/example/rails_example_group.rb

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,7 @@ module RailsExampleGroup
1212
include RSpec::Rails::MinitestLifecycleAdapter
1313
include RSpec::Rails::MinitestAssertionAdapter
1414
include RSpec::Rails::FixtureSupport
15-
16-
if ::Rails::VERSION::MAJOR >= 7
17-
require 'active_support/testing/tagged_logging'
18-
include ActiveSupport::Testing::TaggedLogging
19-
end
15+
include RSpec::Rails::TaggedLoggingAdapter if ::Rails::VERSION::MAJOR >= 7
2016
end
2117
end
2218
end

0 commit comments

Comments
 (0)