Remove old predicates before redefining #2354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonRowe
force-pushed
the
fix-warnings-in-rspec-core
branch
from
9da5de4 to
165222b
Compare
pirj
approved these changes
Jun 10, 2020
| @@ -117,22 +118,27 @@ def rendering_views? | |||
| # to the bug fix in rspec/rspec-core#2736, note some of these | |||
| # predicates are a bit nonsensical, but they exist for backwards | |||
| # compatibility, we can tidy these up in `rspec-rails` 5. | |||
| undef :fixture_path? if respond_to?(:fixture_path?) | |||
There was a problem hiding this comment.
I'm on the fence between this and
config.singleton_class.class_eval { attr_accessor :fixture_path }
# ...
def fixture_path?
!!fixture_path
endThere was a problem hiding this comment.
I'm not, I want to stick with add_setting as much as possible, these work arounds will be removed in the next version major version of rspec-rails.
JonRowe
added a commit
that referenced
this pull request
Jun 10, 2020
JonRowe
added a commit
that referenced
this pull request
Jun 10, 2020
Remove old predicates before redefining
JonRowe
added a commit
that referenced
this pull request
Jun 10, 2020
pirj
pushed a commit
that referenced
this pull request
Aug 2, 2020
This was referenced Mar 8, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an ideal world we'd not do this but because we are mixing into rspec-cores configuration this is preferable to inventing our own.