Skip to content

Commit bd44ddb

Browse files
committed
Suppress redundant configuration logging for rubocop-rake
`rubocop-rake/config/default.yml` is being output twice: ```console $ bundle exec rubocop -d lib/rubocop/rake/inject.rb For /Users/koic/src/github.com/rubocop/rubocop-rake: configuration from /Users/koic/src/github.com/rubocop/rubocop-rake/.rubocop.yml configuration from /Users/koic/src/github.com/rubocop/rubocop-rake/config/default.yml configuration from /Users/koic/.rbenv/versions/3.5-dev/lib/ruby/gems/3.5.0+0/gems/rubocop-1.71.2/config/internal_affairs.yml configuration from /Users/koic/.rbenv/versions/3.5-dev/lib/ruby/gems/3.5.0+0/gems/rubocop-1.71.2/config/internal_affairs.yml Default configuration from /Users/koic/.rbenv/versions/3.5-dev/lib/ruby/gems/3.5.0+0/gems/rubocop-1.71.2/config/default.yml configuration from /Users/koic/src/github.com/rubocop/rubocop-rake/config/default.yml configuration from /Users/koic/src/github.com/rubocop/rubocop-rake/config/default.yml ``` Since it is already logged by `ConfigLoader.load_yaml_configuration`: https://github.com/rubocop/rubocop/blob/v1.71.2/lib/rubocop/config_loader.rb#L71-L82 The unnecessary code on the caller side will be removed.
1 parent f5ba565 commit bd44ddb

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

lib/rubocop/rake/inject.rb

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,8 @@ def self.defaults!
1111
path = CONFIG_DEFAULT.to_s
1212
hash = ConfigLoader.send(:load_yaml_configuration, path)
1313
config = Config.new(hash, path)
14-
puts "configuration from #{path}" if ConfigLoader.debug?
15-
config = ConfigLoader.merge_with_default(config, path)
16-
ConfigLoader.instance_variable_set(:@default_configuration, config)
14+
new_config = ConfigLoader.merge_with_default(config, path)
15+
ConfigLoader.instance_variable_set(:@default_configuration, new_config)
1716
end
1817
end
1918
end

0 commit comments

Comments
 (0)