Deprecate Prism::Translator::Parser

Either use `Prism::Translation::Parser34` or `Parser::Translation::ParserCurrent`.
It's a remnamt of when prism was only able to parse a single ruby version.

Every method instantiates the parser class, so a deprecation in `initialize` is good enough.

In the future this can be cleaned up, currently the autload on the parser class is in the way.

Author: Earlopain

lib/prism/translation.rb

@@ -5,6 +5,7 @@ module Prism
   # syntax trees.
   module Translation # steep:ignore
     autoload :Parser, "prism/translation/parser"
+    autoload :ParserBase, "prism/translation/parser_base"
     autoload :ParserCurrent, "prism/translation/parser_current"
     autoload :Parser33, "prism/translation/parser33"
     autoload :Parser34, "prism/translation/parser34"

lib/prism/translation/parser.rb

@@ -0,0 +1,32 @@
+# frozen_string_literal: true
+
+module Prism
+  module Translation
+    class Parser < ParserBase # :nodoc:
+      def self.inherited(subclass)
+        warn(<<~MSG, uplevel: 1, category: :deprecated)
+          [deprecation]: Using `Prism::Translation::Parser` is deprecated and will be \
+          removed in the next major version. Use `Prism::Translation::Parser34` instead.
+        MSG
+        super
+      end
+
+      def initialize(builder = Prism::Translation::Parser::Builder.new, parser: Prism)
+        # Filter parser frames, find first user code
+        offset = caller(1..5)&.find_index do |loc|
+          !loc.include?("/lib/parser/base.rb")
+        end
+
+        warn(<<~MSG, uplevel: 1 + (offset || 0), category: :deprecated)
+          [deprecation]: Using `Prism::Translation::Parser` is deprecated and will be \
+          removed in the next major version. Use `Prism::Translation::Parser34` instead.
+        MSG
+        super
+      end
+
+      def version # :nodoc:
+        34
+      end
+    end
+  end
+end

lib/prism/translation/parser/builder.rb

@@ -2,7 +2,7 @@
 
 module Prism
   module Translation
-    class Parser
+    class Parser < ParserBase
       # A builder that knows how to convert more modern Ruby syntax
       # into whitequark/parser gem's syntax tree.
       class Builder < ::Parser::Builders::Default

lib/prism/translation/parser/compiler.rb

@@ -2,7 +2,7 @@
 
 module Prism
   module Translation
-    class Parser
+    class Parser < ParserBase
       # A visitor that knows how to convert a prism syntax tree into the
       # whitequark/parser gem's syntax tree.
       class Compiler < ::Prism::Compiler

lib/prism/translation/parser/lexer.rb

@@ -5,7 +5,7 @@
 
 module Prism
   module Translation
-    class Parser
+    class Parser < ParserBase
       # Accepts a list of prism tokens and converts them into the expected
       # format for the parser gem.
       class Lexer

lib/prism/translation/parser33.rb

@@ -2,8 +2,8 @@
 
 module Prism
   module Translation
-    # This class is the entry-point for Ruby 3.3 of `Prism::Translation::Parser`.
-    class Parser33 < Parser
+    # This class is the entry-point for Ruby 3.3.
+    class Parser33 < ParserBase
       def version # :nodoc:
         33
       end

lib/prism/translation/parser34.rb

@@ -2,8 +2,8 @@
 
 module Prism
   module Translation
-    # This class is the entry-point for Ruby 3.4 of `Prism::Translation::Parser`.
-    class Parser34 < Parser
+    # This class is the entry-point for Ruby 3.4.
+    class Parser34 < ParserBase
       def version # :nodoc:
         34
       end

lib/prism/translation/parser35.rb

@@ -2,8 +2,8 @@
 
 module Prism
   module Translation
-    # This class is the entry-point for Ruby 3.5 of `Prism::Translation::Parser`.
-    class Parser35 < Parser
+    # This class is the entry-point for Ruby 3.5.
+    class Parser35 < ParserBase
       def version # :nodoc:
         35
       end

lib/prism/translation/parser_base.rb

@@ -18,7 +18,7 @@ module Translation
     # whitequark/parser gem's syntax tree. It inherits from the base parser for
     # the parser gem, and overrides the parse* methods to parse with prism and
     # then translate.
-    class Parser < ::Parser::Base
+    class ParserBase < ::Parser::Base # :nodoc:
       Diagnostic = ::Parser::Diagnostic # :nodoc:
       private_constant :Diagnostic
 
@@ -66,7 +66,7 @@ def initialize(message, level, reason, location)
       def initialize(builder = Prism::Translation::Parser::Builder.new, parser: Prism)
         if !builder.is_a?(Prism::Translation::Parser::Builder)
           warn(<<~MSG, uplevel: 1, category: :deprecated)
-            [deprecation]: The builder passed to `Prism::Translation::Parser.new` is not a \
+            [deprecation]: The builder passed to `#{self.class}.new` is not a \
             `Prism::Translation::Parser::Builder` subclass. This will raise in the next major version.
           MSG
         end
@@ -75,10 +75,6 @@ def initialize(builder = Prism::Translation::Parser::Builder.new, parser: Prism)
         super(builder)
       end
 
-      def version # :nodoc:
-        34
-      end
-
       # The default encoding for Ruby files is UTF-8.
       def default_encoding
         Encoding::UTF_8
@@ -359,8 +355,15 @@ def convert_for_prism(version)
       require_relative "parser/compiler"
       require_relative "parser/lexer"
 
+      # This can be simplified by moving `Prism::Translation::ParserBase` to
+      # `Prism::Translation::Parser::Base` after `Prism::Translation::Parser` has been removed.
+      Compiler = Parser::Compiler
       private_constant :Compiler
+      Lexer = Parser::Lexer
       private_constant :Lexer
+
+      Parser.private_constant :Compiler
+      Parser.private_constant :Lexer
     end
   end
 end

prism.gemspec

@@ -96,6 +96,7 @@ Gem::Specification.new do |spec|
     "lib/prism/string_query.rb",
     "lib/prism/translation.rb",
     "lib/prism/translation/parser.rb",
+    "lib/prism/translation/parser_base.rb",
     "lib/prism/translation/parser_current.rb",
     "lib/prism/translation/parser33.rb",
     "lib/prism/translation/parser34.rb",
@@ -119,6 +120,7 @@ Gem::Specification.new do |spec|
     "rbi/prism/reflection.rbi",
     "rbi/prism/string_query.rbi",
     "rbi/prism/translation/parser.rbi",
+    "rbi/prism/translation/parser_base.rbi",
     "rbi/prism/translation/parser33.rbi",
     "rbi/prism/translation/parser34.rbi",
     "rbi/prism/translation/parser35.rbi",

rbi/prism/translation/parser.rbi

@@ -1,11 +1,6 @@
 # typed: strict
 
-# We keep these shims in here because our client libraries might not have parser
-# in their bundle.
-module Parser; end
-class Parser::Base; end
-
-class Prism::Translation::Parser < Parser::Base
+class Prism::Translation::Parser < Prism::Translation::ParserBase
   sig { overridable.returns(Integer) }
   def version; end
 end

rbi/prism/translation/parser33.rbi

@@ -1,6 +1,6 @@
 # typed: strict
 
-class Prism::Translation::Parser33 < Prism::Translation::Parser
+class Prism::Translation::Parser33 < Prism::Translation::ParserBase
   sig { override.returns(Integer) }
   def version; end
 end

rbi/prism/translation/parser34.rbi

@@ -1,6 +1,6 @@
 # typed: strict
 
-class Prism::Translation::Parser34 < Prism::Translation::Parser
+class Prism::Translation::Parser34 < Prism::Translation::ParserBase
   sig { override.returns(Integer) }
   def version; end
 end

rbi/prism/translation/parser35.rbi

@@ -1,6 +1,6 @@
 # typed: strict
 
-class Prism::Translation::Parser35 < Prism::Translation::Parser
+class Prism::Translation::Parser35 < Prism::Translation::ParserBase
   sig { override.returns(Integer) }
   def version; end
 end

rbi/prism/translation/parser_base.rbi

@@ -0,0 +1,11 @@
+# typed: strict
+
+# We keep these shims in here because our client libraries might not have parser
+# in their bundle.
+module Parser; end
+class Parser::Base; end
+
+class Prism::Translation::ParserBase < Parser::Base
+  sig { overridable.returns(Integer) }
+  def version; end
+end

test/prism/ruby/parser_test.rb

@@ -155,6 +155,23 @@ def test_non_prism_builder_class_deprecated
       assert_empty(warnings)
     end
 
+    def test_version_less_parser_deprecated
+      warnings = capture_warnings { Prism::Translation::Parser.parse("foo") }
+
+      assert_include(warnings, "#{__FILE__}:#{__LINE__ - 2}")
+      assert_include(warnings, "`Prism::Translation::Parser` is deprecated")
+
+      warnings = capture_warnings { Prism::Translation::Parser.new }
+
+      assert_include(warnings, "#{__FILE__}:#{__LINE__ - 2}")
+      assert_include(warnings, "`Prism::Translation::Parser` is deprecated")
+
+      warnings = capture_warnings { Class.new(Prism::Translation::Parser) }
+
+      assert_include(warnings, "#{__FILE__}:#{__LINE__ - 2}")
+      assert_include(warnings, "`Prism::Translation::Parser` is deprecated")
+    end
+
     if RUBY_VERSION >= "3.3"
       def test_current_parser_for_current_ruby
         major, minor, _patch = Gem::Version.new(RUBY_VERSION).segments