Skip to content

Recommendation #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ghost opened this issue Feb 23, 2018 · 0 comments
Open

Recommendation #1

ghost opened this issue Feb 23, 2018 · 0 comments

Comments

@ghost
Copy link

ghost commented Feb 23, 2018

Network-Util.sh
There are easier ways to get network information,
Since you are making utilities out of it and it is a bit more advanced than I know how to script, I just wanna let you know that there are ways to get information about a network. Such as obtaining an IP address. lines 58-76: What is trying to be accomplished here? (please leave comments on your code so people can help with it,) From what it looks like you're trying to gain IP info and root permission. Since you are setting a function, it would be easier to use a command that already gives you IP information (hostname -I). Also From what is being displayed from line 99, you're looking for a loopback. you can already tell if there's a loopback from IP add command. But this is just a recommendation. (trying to help ya :) )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants