fix: async functions in tool specs (#19000)

Author: logan-markewich

llama-index-core/llama_index/core/tools/tool_spec/base.py

@@ -94,32 +94,10 @@ def to_tool_list(
                     "spec_functions must be of type: List[Union[str, Tuple[str, str]]]"
                 )
 
-            if func_sync is None:
-                if func_async is not None:
-                    func_sync = patch_sync(func_async)
-                else:
-                    raise ValueError(
-                        f"Could not retrieve a function for spec: {func_spec}"
-                    )
-
             tool = FunctionTool.from_defaults(
                 fn=func_sync,
                 async_fn=func_async,
                 tool_metadata=metadata,
             )
             tool_list.append(tool)
         return tool_list
-
-
-def patch_sync(func_async: AsyncCallable) -> Callable:
-    """Patch sync function from async function."""
-
-    def patched_sync(*args: Any, **kwargs: Any) -> Any:
-        try:
-            loop = asyncio.get_event_loop()
-        except RuntimeError:
-            loop = asyncio.new_event_loop()
-            asyncio.set_event_loop(loop)
-        return loop.run_until_complete(func_async(*args, **kwargs))
-
-    return patched_sync

llama-index-core/llama_index/core/vector_stores/types.py

@@ -95,7 +95,7 @@ class MetadataFilter(BaseModel):
     r"""
     Comprehensive metadata filter for vector stores to support more operators.
 
-    Value uses Strict* types, as int, float and str are compatible types and were all
+    Value uses Strict types, as int, float and str are compatible types and were all
     converted to string before.
 
     See: https://docs.pydantic.dev/latest/usage/types/#strict-types

llama-index-core/tests/readers/file/test_base.py

@@ -99,7 +99,7 @@ def test_SimpleDirectoryReader_empty(data_path):
 
 def test_SimpleDirectoryReader_file_limit(data_path):
     r = SimpleDirectoryReader(input_dir=data_path, recursive=True, num_files_limit=2)
-    assert [f.name for f in r.input_files] == ["excluded_0.txt", "file_0.md"]
+    assert len(r.input_files) == 2
 
 
 def test_SimpleDirectoryReader_list_resources(data_path):

llama-index-core/tests/tools/tool_spec/test_base.py

@@ -28,6 +28,7 @@ class TestToolSpec(BaseToolSpec):
         "bar",
         "abc",
         "abc_with_ctx",
+        "async_only_fn",
     ]
 
     def foo(self, arg1: str, arg2: int) -> str:
@@ -46,6 +47,10 @@ async def abar(self, arg1: bool) -> str:
         """Abar."""
         return self.bar(arg1=arg1)
 
+    async def async_only_fn(self) -> str:
+        """Async only fn."""
+        return "async only fn"
+
     def abc(self, arg1: str) -> str:
         # NOTE: no docstring
         return f"bar {arg1}"
@@ -62,7 +67,7 @@ def test_tool_spec() -> None:
     tool_spec = TestToolSpec()
     # first is foo, second is bar
     tools = tool_spec.to_tool_list()
-    assert len(tools) == 4
+    assert len(tools) == 5
     assert tools[0].metadata.name == "foo"
     assert tools[0].metadata.description == "foo(arg1: str, arg2: int) -> str\nFoo."
     assert tools[0].fn("hello", 1) == "foo hello 1"
@@ -101,7 +106,7 @@ def test_tool_spec() -> None:
             ),
         }
     )
-    assert len(tools) == 4
+    assert len(tools) == 5
     assert tools[0].metadata.name == "foo_name"
     assert tools[0].metadata.description == "foo_description"
     assert tools[0].metadata.fn_schema is not None
@@ -121,19 +126,28 @@ async def test_tool_spec_async() -> None:
     """Test async_fn of tool spec."""
     tool_spec = TestToolSpec()
     tools = tool_spec.to_tool_list()
-    assert len(tools) == 4
+    assert len(tools) == 5
+
     assert await tools[0].async_fn("hello", 1) == "foo hello 1"
     assert str(await tools[1].acall(True)) == "bar True"
 
+    assert tools[0].fn("hello", 1) == "foo hello 1"
+    assert str(tools[1](True)) == "bar True"
+
 
 def test_async_patching() -> None:
     # test sync patching of async function
     tool_spec = TestToolSpec()
-    tool_spec.spec_functions = ["afoo"]
+    tool_spec.spec_functions = ["afoo", "async_only_fn"]
     tools = tool_spec.to_tool_list()
-    assert len(tools) == 1
+    assert len(tools) == 2
     assert tools[0].fn("hello", 1) == "foo hello 1"
 
+    assert tools[0].metadata.name == "afoo"
+    assert tools[0].metadata.description == "afoo(arg1: str, arg2: int) -> str\nAfoo."
+    assert tools[1].metadata.name == "async_only_fn"
+    assert tools[1].metadata.description == "async_only_fn() -> str\nAsync only fn."
+
 
 def test_tool_spec_subset() -> None:
     """Test tool spec subset."""

llama-index-integrations/tools/llama-index-tools-playwright/README.md

@@ -16,7 +16,9 @@ pip install llama-index-tools-playwright
 In order to use this tool, you need to have a async Playwright browser instance. You can hook one up by running the following code:
 
 ```python
-browser = PlaywrightToolSpec.create_async_playwright_browser(headless=False)
+browser = await PlaywrightToolSpec.create_async_playwright_browser(
+    headless=False
+)
 playwright_tool = PlaywrightToolSpec.from_async_browser(browser)
 ```
 

llama-index-packs/llama-index-packs-raptor/pyproject.toml

@@ -42,6 +42,7 @@ dependencies = [
     "umap-learn>=0.5.5",
     "scikit-learn",
     "llama-index-core>=0.12.0,<0.13",
+    "numpy<=2.2",
 ]
 
 [tool.codespell]