Skip to content

Migrate from poetry to uv #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 30, 2025
Merged

Migrate from poetry to uv #22

merged 9 commits into from
May 30, 2025

Conversation

tothtamas28
Copy link
Collaborator

No description provided.

@tothtamas28 tothtamas28 mentioned this pull request Apr 29, 2025
Merged
@juliankuners
update nixpkgs to unstable
f31bc4c 
nixpkgs on previously 22.05 changed something in regard to
`python.interpreter`. Updating to a version atleast as recent as used in
other runtime verification repositories fixes this.
@juliankuners
Copy link
Collaborator

Hey @tothtamas28, I'd like to push my changes for this pull request to this branch, but I do not seem to have access rights for this repository. I checked that I am indeed using the ssh remote. Could you please take a look?

@juliankuners juliankuners marked this pull request as ready for review April 30, 2025 13:48
@juliankuners
Copy link
Collaborator

I added the migration from poetry2nix to uv2nix. In addition, I added a Python entry point example in order to test shipping applications with uv2nix.

In addition, I updated nixpkgs from nixos-22.05 to nixos-unstable as python.interpreter broke the uv nix develop shell. Updating nixpkgs to a version that is at least as recent as the one used in runtime verification repositories fixed this.

@tothtamas28 tothtamas28 requested a review from ehildenb April 30, 2025 13:58
@juliankuners
Copy link
Collaborator

juliankuners commented Apr 30, 2025 •
edited
Loading

Today, @palinatolmach identified that the version of uv in CI/CD is not identical to the version used by uv2nix and the nix develop shell, see here. This can cause the updated uv lock file to potentially be incompatible with uv2nix.

We'll also want to fix this in this pull request prior to merging.

@tothtamas28 tothtamas28 marked this pull request as draft April 30, 2025 17:37
@juliankuners juliankuners changed the title Migrate from poetry to uv [Do not merge yet] Migrate from poetry to uv Apr 30, 2025
@juliankuners juliankuners changed the title [Do not merge yet] Migrate from poetry to uv Migrate from poetry to uv Apr 30, 2025
@tothtamas28
Copy link
Collaborator Author

We'll also want to fix this in this pull request prior to merging.

Marking the PR as draft until then.

tothtamas28
tothtamas28 commented May 22, 2025
View reviewed changes
@juliankuners juliankuners marked this pull request as ready for review May 22, 2025 14:28
@juliankuners
Copy link
Collaborator

As discussed on another occasion, GitHub workflows are not included in this python project template, but the nix flake file was adjusted to allow for workflows to be added that update the respective dependencies.

With that, this pull request is ready for review and merging.

@juliankuners
Copy link
Collaborator

I changed nixpkgs from nixos-unstable to 25.05 to ensure longer availability of nix caches, as it's not planned to update nixpkgs automatically by CI for this repository.

@tothtamas28 tothtamas28 requested a review from jberthold May 29, 2025 11:55
jberthold
jberthold approved these changes May 30, 2025
View reviewed changes
Copy link
Member

@jberthold jberthold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not fully familiar with how the template is applied to projects but this all makes sense and is what we already did in projects converted to uv

@tothtamas28 tothtamas28 merged commit 607be72 into master May 30, 2025
7 checks passed
@tothtamas28 tothtamas28 deleted the poetry-to-uv branch May 30, 2025 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliankuners juliankuners juliankuners left review comments

@jberthold jberthold jberthold approved these changes

@palinatolmach palinatolmach Awaiting requested review from palinatolmach

@F-WRunTime F-WRunTime Awaiting requested review from F-WRunTime

@ehildenb ehildenb Awaiting requested review from ehildenb

Assignees

@juliankuners juliankuners

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tothtamas28 @juliankuners @jberthold