Skip to content

fix: support auto-closing for triple backticks#17051

Merged
bors merged 1 commit into
rust-lang:masterfrom
roife:auto-closing-for-triple-backticks
Apr 13, 2024
Merged

fix: support auto-closing for triple backticks#17051
bors merged 1 commit into
rust-lang:masterfrom
roife:auto-closing-for-triple-backticks

Conversation

@roife
Copy link
Copy Markdown
Member

@roife roife commented Apr 11, 2024

It might fix #16051, see #16051 (comment)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 11, 2024
@roife
Copy link
Copy Markdown
Member Author

roife commented Apr 11, 2024

If auto-closing for backticks only works in comments, that would be even better.

Perhaps we can submit a related API (something like onlyIn) to VS Code. 🤔

@Veykril
Copy link
Copy Markdown
Member

Veykril commented Apr 13, 2024

Sounds reasonable! Thanks!
@bors r+

@bors
Copy link
Copy Markdown
Contributor

bors commented Apr 13, 2024

📌 Commit 4346bbc has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Copy Markdown
Contributor

bors commented Apr 13, 2024

⌛ Testing commit 4346bbc with merge e1d7ce7...

@bors
Copy link
Copy Markdown
Contributor

bors commented Apr 13, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing e1d7ce7 to master...

@bors bors merged commit e1d7ce7 into rust-lang:master Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auto-closing backticks does not work well combined with triple backtick code blocks.

4 participants