Skip to content

fix: cleanup CI workflow #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nyonson merged 4 commits into from
May 14, 2025
Merged

fix: cleanup CI workflow #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a4a58c5
fix: new clippy lints for string formats
nyonson May 14, 2025
4f398be
fix: cleanup CI workflow
nyonson May 14, 2025
17a25a6
fix: clean up authors
nyonson May 14, 2025
13dede9
fix: add a cron check to catch upstream breaks
nyonson May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .cargo/config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# Opt in to the v3 MSRV-aware resolver.
[resolver]
incompatible-rust-versions = "fallback"
1 change: 0 additions & 1 deletion .clippy.toml
View file
Open in desktop

This file was deleted.

117 changes: 51 additions & 66 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,81 +1,66 @@
name: Build & Test
name: CI

on:
push:
branches:
- main
pull_request:
branches:
- main

jobs:
proxy:
runs-on: ubuntu-latest
# Quick canary of code as well as potential issues with upcoming toolchains.
check:
strategy:
matrix:
toolchain: [stable, beta, nightly]
steps:
- uses: actions/checkout@v3
- name: Update Toolchain
run: |
rustup default ${{ matrix.toolchain }}
rustup component add --toolchain ${{ matrix.toolchain }} rustfmt
rustup component add --toolchain ${{ matrix.toolchain }} clippy
rustup update ${{ matrix.toolchain }}
- name: Lint
run: |
cargo clippy --package bip324-proxy --all-targets
- name: Format
run: |
cargo fmt --package bip324-proxy -- --check
- name: Build
run: |
cargo build --package bip324-proxy --verbose
cargo build --all --verbose --no-default-features
cargo build --all --verbose --all-features
- name: Test
run: |
cargo test --package bip324-proxy --verbose

protocol:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: extractions/setup-just@v3
- uses: actions-rust-lang/setup-rust-toolchain@v1
with:
toolchain: ${{ matrix.toolchain }}
components: clippy,rustfmt
- run: just check
# Build and test the code across platforms.
test:
strategy:
matrix:
# Minumum Supported Rust Version (MSRV) is 1.63.0.
toolchain: [1.63.0, stable, beta, nightly]
platform: [ubuntu-latest, macos-latest, windows-latest]
runs-on: ${{ matrix.platform }}
steps:
- uses: actions/checkout@v4
- uses: extractions/setup-just@v3
- uses: actions-rust-lang/setup-rust-toolchain@v1
- run: just test unit
features:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: extractions/setup-just@v3
- uses: actions-rust-lang/setup-rust-toolchain@v1
- run: just test features
msrv:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: extractions/setup-just@v3
- uses: actions-rust-lang/setup-rust-toolchain@v1
- run: just test msrv
min-versions:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: extractions/setup-just@v3
- uses: actions-rust-lang/setup-rust-toolchain@v1
with:
toolchain: nightly
- run: just test min-versions
no-std:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Update Toolchain
run: |
rustup default ${{ matrix.toolchain }}
rustup component add --toolchain ${{ matrix.toolchain }} rustfmt
rustup component add --toolchain ${{ matrix.toolchain }} clippy
rustup update ${{ matrix.toolchain }}
- name: Lint
run: |
cargo clippy --package bip324 --all-targets
- name: Format
run: |
cargo fmt --package bip324 -- --check
- name: Build
# Build with default features, all, and none.
# Then build with specific feature sub-sets.
run: |
cargo build --package bip324 --verbose
cargo build --package bip324 --verbose --all-features
cargo build --package bip324 --verbose --no-default-features
cargo build --package bip324 --verbose --no-default-features --features alloc
- name: Test
# Test with default features, all, and none.
# Then test with specific feature sub-sets.
run: |
cargo test --package bip324 --verbose
cargo test --package bip324 --verbose --all-features
cargo test --package bip324 --verbose --no-default-features
cargo test --package bip324 --verbose --no-default-features --features alloc
- name: Check No Standard Library Support
# The cross tool used to test in a no standard library environment doesn't play nice with our MSRV, so limiting to just stable toolchain.
if: matrix.toolchain == 'stable'
run: |
rustup target add --toolchain ${{ matrix.toolchain }} thumbv7m-none-eabi
cargo install cross --locked
cross build --package bip324 --target thumbv7m-none-eabi --no-default-features --features alloc

- uses: actions/checkout@v4
- uses: extractions/setup-just@v3
- uses: actions-rust-lang/setup-rust-toolchain@v1
- run: just test no-std
25 changes: 25 additions & 0 deletions .github/workflows/weekly-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
# Attempt to detect any upcoming breaking changes if CI hasn't been run in awhile.
name: Weekly Check

on:
# Allows manual triggering.
workflow_dispatch:
schedule:
# Run at midnight on Sundays.
- cron: "0 0 * * 0"

jobs:
# Quick canary of code as well as potential issues with upcoming toolchains.
check:
strategy:
matrix:
toolchain: [stable, beta, nightly]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: extractions/setup-just@v3
- uses: actions-rust-lang/setup-rust-toolchain@v1
with:
toolchain: ${{ matrix.toolchain }}
components: clippy,rustfmt
- run: just check
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
Cargo.lock
/target
# IDEs
.vscode/
1 change: 0 additions & 1 deletion AUTHORS
View file
Open in desktop

This file was deleted.

Loading