Skip to content

ElligatorSwift "A/B" enum should have better-named variants #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
apoelstra opened this issue Sep 12, 2024 · 4 comments · Fixed by #752
Closed

ElligatorSwift "A/B" enum should have better-named variants #741

apoelstra opened this issue Sep 12, 2024 · 4 comments · Fixed by #752

Comments

@apoelstra
Copy link
Member

I think we can create a new enum, deprecate the old one, and use Into generics to make this a non-breaking change for most users.

@Kixunil
Copy link
Collaborator

Kixunil commented Sep 12, 2024

Good idea, especially if you mean Into<NewEnum>.

@Davidson-Souza
Copy link
Contributor

As the one to blame for this unfortunate naming, I agree that it should be clearer. The comments use "Initiator" and "Responder'. If you consider this is used in during a connection handshake, I think those makes sense.

@liamaharon
Copy link
Contributor

Any suggestions for a more creative name for the new enum than ElligatorSwiftPartyV2?

@apoelstra
Copy link
Member Author

I think we could shorten it to Party since it's in the ellswift module, the term "party" isn't used anywhere else, and with the long variant names it'll be better to have a short enum name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants