-
Notifications
You must be signed in to change notification settings - Fork 290
ElligatorSwift "A/B" enum should have better-named variants #741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Good idea, especially if you mean |
As the one to blame for this unfortunate naming, I agree that it should be clearer. The comments use "Initiator" and "Responder'. If you consider this is used in during a connection handshake, I think those makes sense. |
Any suggestions for a more creative name for the new enum than |
I think we could shorten it to |
I think we can create a new enum, deprecate the old one, and use
Into
generics to make this a non-breaking change for most users.The text was updated successfully, but these errors were encountered: