String insertion #584
Open
String insertion #584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riley-williams
commented
Jul 14, 2025
Comment on lines
+732
to
+735
| let mut buf = [0u8; 4]; | ||
| let encoded = ch.encode_utf8(&mut buf); | ||
| core::ptr::copy_nonoverlapping( | ||
| encoded.as_ptr(), | ||
| self.vec.as_mut_ptr().add(idx), | ||
| ch_len, | ||
| ); |
There was a problem hiding this comment.
This differs from the std::String implementation which uses an unstable method to encode directly into the destination buffer.
core::char::encode_utf8_raw_unchecked(ch as u32, self.vec.as_mut_ptr().add(idx));There's probably a better way than what I've done here.
riley-williams
force-pushed
the
string-insertion
branch
from
6271fff to
0bc5a63
Compare
|
Failing because of some existing clippy issues, opened a separate PR to fix them: #585 |
riley-williams
force-pushed
the
string-insertion
branch
from
0bc5a63 to
9ad10ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically just copies the implementations of
insertandinsert_strfromstd::Stringwith minor modification.