Skip to content

setup MacOS CI #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
budziq opened this issue Jul 12, 2017 · 16 comments · Fixed by #282
Closed

setup MacOS CI #238

budziq opened this issue Jul 12, 2017 · 16 comments · Fixed by #282
Labels

Comments

@budziq
Copy link
Collaborator

budziq commented Jul 12, 2017

Our first Windows contributor has stumbled on:

both of these problems would be easily averted if we had more robust CI.

@budziq budziq added the easy label Jul 12, 2017
@anna-liao
Copy link
Contributor

@budziq Can you elaborate on what you mean by a "more robust CI"? I could work on the MacOS CI.

@budziq
Copy link
Collaborator Author

budziq commented Aug 19, 2017

Hi @anna-liao,

Awesome! 👍
Basically we would like to update our CI to use https://github.com/japaric/trust with Linux and MacOS on travis and windows builds appveyor (basically one has to follow the instructions in trust repo).

there are two additional notes:

  • we upload build artifacts (book built with MdBook) to our gh-pages on each successfull commit and merged PR
  • we have a cron build on travis with all dependencies set to "*" in order to catch buildbreaks with latest crate versions.

If you'd like to work on it or have any questions please do not heasitate to ask here. 😃

@anna-liao
Copy link
Contributor

@budziq For the github tokens, do I just use my own when I am testing a fork, and then it will be replaced later when it is merged to rust-lang-nursery/rust-cookbook? The .yml configuration files require an encrypted version of the github personal access tokens.

@budziq
Copy link
Collaborator Author

budziq commented Aug 20, 2017

@anna-liao
yep just use your own tokens for testing on your forks and substitute the travis token with the one already present in our repo when making the PR.

In case of appveyor I am waiting for member of rust-lang-nursery to enable it on canonical account and untill that time we will operate on a fork.

@alexcrichton
Copy link
Member

@budziq AppVeyor is enabled, see #270

@budziq
Copy link
Collaborator Author

budziq commented Aug 20, 2017

Thanks @alexcrichton!
Unfortunately the appveyor is still connected to rust-lang-libs instead of rust-lang-nursery which results in non nursery collaborators such as myself being unable to change settings, start and restart builds (the github rights are not propagated as the appveyor landing url is different than canonical repo address).

At the moment we will work off my personal appveyor account where at least I can admin and grant rights.
Thanks for bootstrapping us and for your time :)

@budziq
Copy link
Collaborator Author

budziq commented Aug 21, 2017

Darn. I can't even even switch appveyor instances. So we are stuck with this instance I have no control of.

@alexcrichton Is there a possibility to ad myself as admin for this single repo on appveyor rust-lang-libs without escalating privileges for other projects (like I am in case of travis.ci)?

Being the sole active maintainer without real admin rights is no fun :/

@alexcrichton
Copy link
Member

I don't know what the rust-lang-nursery org is on AppVeyor, afaik we don't own or have control over that. I also unfortunately don't know how to give out granular permissions in appveyor. If you'd like you can just set it up and do your own thing.

@budziq
Copy link
Collaborator Author

budziq commented Aug 22, 2017

Fine grained control can be done by adding separate role and and enabling permissions for that role:

These should do the trick. But if its problematic I'll live with current setup without admin rights.
Thanks for your time :)

@alexcrichton
Copy link
Member

Ok I've updated now, try again?

Thanks for the info!

@budziq
Copy link
Collaborator Author

budziq commented Aug 22, 2017

Awesome, It works!
Thanks a lot @alexcrichton !

@budziq
Copy link
Collaborator Author

budziq commented Aug 22, 2017

@anna-liao there are no more blockers. Are you willing to work on this issue?

@anna-liao
Copy link
Contributor

@budziq Thanks! I tried following the instructions at https://github.com/japaric/trust and tried it out in my fork, but it doesn't seem to be triggering Travis CI and Appveyor. I won't be able to look into this more until next week, so if someone else would like to set it up, please go for it.

@budziq
Copy link
Collaborator Author

budziq commented Aug 22, 2017

@anna-liao

it doesn't seem to be triggering Travis CI and Appveyor

Most likely you forgot to go into "settings (gear icon in your fork) > Integrations & services" and enable travis and appveyor integrations.

if someone else would like to set it up, please go for it.

There is no rush :) I'll provide minimal appveyor.yml based on Alex's PR so the CI does not constantly error's out until you can approach the issue.

edit:
minimal windows CI #271

@budziq budziq changed the title setup Windows and MacOS CI setup MacOS CI Sep 19, 2017
@budziq
Copy link
Collaborator Author

budziq commented Sep 24, 2017

Sorry @anna-liao , I needed the MacOS CI up and running before rustfest zurich. I hope that you'll be able to find something interesting to work on on https://gitter.im/rust-impl-period/WG-libs-cookbook!

@anna-liao
Copy link
Contributor

no worries, totally understand!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants