-
Notifications
You must be signed in to change notification settings - Fork 302
setup MacOS CI #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@budziq Can you elaborate on what you mean by a "more robust CI"? I could work on the MacOS CI. |
Hi @anna-liao, Awesome! 👍 there are two additional notes:
If you'd like to work on it or have any questions please do not heasitate to ask here. 😃 |
@budziq For the github tokens, do I just use my own when I am testing a fork, and then it will be replaced later when it is merged to rust-lang-nursery/rust-cookbook? The .yml configuration files require an encrypted version of the github personal access tokens. |
@anna-liao In case of appveyor I am waiting for member of rust-lang-nursery to enable it on canonical account and untill that time we will operate on a fork. |
Thanks @alexcrichton! At the moment we will work off my personal appveyor account where at least I can admin and grant rights. |
Darn. I can't even even switch appveyor instances. So we are stuck with this instance I have no control of. @alexcrichton Is there a possibility to ad myself as admin for this single repo on appveyor rust-lang-libs without escalating privileges for other projects (like I am in case of travis.ci)? Being the sole active maintainer without real admin rights is no fun :/ |
I don't know what the rust-lang-nursery org is on AppVeyor, afaik we don't own or have control over that. I also unfortunately don't know how to give out granular permissions in appveyor. If you'd like you can just set it up and do your own thing. |
Fine grained control can be done by adding separate role and and enabling permissions for that role:
These should do the trick. But if its problematic I'll live with current setup without admin rights. |
Ok I've updated now, try again? Thanks for the info! |
Awesome, It works! |
@anna-liao there are no more blockers. Are you willing to work on this issue? |
@budziq Thanks! I tried following the instructions at https://github.com/japaric/trust and tried it out in my fork, but it doesn't seem to be triggering Travis CI and Appveyor. I won't be able to look into this more until next week, so if someone else would like to set it up, please go for it. |
Most likely you forgot to go into "settings (gear icon in your fork) > Integrations & services" and enable travis and appveyor integrations.
There is no rush :) I'll provide minimal appveyor.yml based on Alex's PR so the CI does not constantly error's out until you can approach the issue. edit: |
Sorry @anna-liao , I needed the MacOS CI up and running before rustfest zurich. I hope that you'll be able to find something interesting to work on on https://gitter.im/rust-impl-period/WG-libs-cookbook! |
no worries, totally understand! |
Our first Windows contributor has stumbled on:
both of these problems would be easily averted if we had more robust CI.
The text was updated successfully, but these errors were encountered: