add rfc merge procedure #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 25, 2017
aturon
reviewed
Apr 25, 2017
| Add the following labels to the issue: | ||
|
|
||
| - `B-rfc-approved` | ||
| - `B-unstable` |
There was a problem hiding this comment.
I think B-unstable is only supposed to be applied when the impl has landed.
aturon
reviewed
Apr 25, 2017
| title: RFC Merge Procedure | ||
| --- | ||
|
|
||
| Once an RFC has been accepted (i.e., the final comment period is |
There was a problem hiding this comment.
Probably good to clarify that this is after an FCP where no serious new issues/arguments were raised.
steveklabnik
approved these changes
Apr 26, 2017
|
🎊 |
|
Oh no, GitHub didn't show me @aturon 's comments. @nikomatsakis looks like you'll have to send in a second PR, sorry :/ |
|
There's no mention of what the title of the tracking issue should be. |
|
Also, Step 2. can be done much easier now with the new GitHub feature that lets you modify the PR branch by default - all I had to do was:
|
eddyb
reviewed
May 10, 2017
| ``` | ||
| **Huzzah!** The @rust-lang/lang team has decided **to accept** this RFC. | ||
|
|
||
| To track further discussion, subscribe to the tracking issue here: rust-lang/rust#41517 |
There was a problem hiding this comment.
This uses a specific number instead of a placeholder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @steveklabnik