Skip to content
This repository was archived by the owner on Mar 19, 2024. It is now read-only.

[Rust-analyzer] Code blocks on datatips (hover to type/ hover to doc) doesn't highlight #158

Closed
GrayJack opened this issue May 11, 2020 · 3 comments · Fixed by #171
Closed

Comments

@GrayJack
Copy link

GrayJack commented May 11, 2020

I noticed a while that code blocks on datatips (hover to type/ hover to doc) doesn't highlight like RLS since I started using RA. Maybe it's possible to look into that since RA became the official LS.

Example

@alexheretic
Copy link
Member

Yep this isn't ideal. rust-analyzer uses a different (also valid) way to provide this as markdown, whereas RLS would send sort of {lang:"rust", text: "let foo = 123"} kind of thing.

r.a is sending something like {markdown:```rust\nlet foo = 123\n```}. This is supported, I'm not sure why atom isn't using the indicated syntax highlighting. It'll need to be investigated in atom-languageclient.

@GrayJack
Copy link
Author

I noticed that this package is using your fork of atom-languageclient. Should I open a issue on your fork repository?

@alexheretic
Copy link
Member

I'll raise an issue with main branch, I was going to provide an LSP message example. In general I want to try to work with the semi-dead upstream as much as I can, ie I have prs for all my patches.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants