Skip to content
This repository was archived by the owner on Mar 19, 2024. It is now read-only.

"Ghost" window stays open after closing atom #196

Closed
autumnull opened this issue Jul 14, 2021 · 8 comments · Fixed by #198
Closed

"Ghost" window stays open after closing atom #196

autumnull opened this issue Jul 14, 2021 · 8 comments · Fixed by #198

Comments

@autumnull
Copy link
Contributor

When atom is closed with atom-ide-rust enabled, a "ghost" window appears, showing the last open file but without any syntax highlighting or most of the UI.

Atom before clicking the cross to close:
image

Atom after clicking the cross as a "ghost" window.
image

@aminya
Copy link
Contributor

aminya commented Jul 15, 2021

That's because Atom waits until rust analyzer is closed in the background. We could make it close immediately without waiting for the close response, but that may result in a zombie rust-analyzer process.

@autumnull
Copy link
Contributor Author

Is the ghost window meant to automatically close after rust-analyzer closes ? because it doesn't for me, i have to click the cross again.

@aminya
Copy link
Contributor

aminya commented Jul 15, 2021

Yes, it should close automatically. How long do you wait?

@autumnull
Copy link
Contributor Author

autumnull commented Jul 15, 2021

It doesn't close at all however long i wait, even when i can see that the rust-analyzer process has terminated in my task manager. I've waited several minutes and then got bored.

EDIT: I should note that I've implemented the changes from this pull request manually, because otherwise rust-analyzer would not start at all. I can imagine this might make a difference...

@aminya
Copy link
Contributor

aminya commented Jul 15, 2021

@autumnull I merged and published the pull request you mentioned. Do you still have a problem with the new version?

@autumnull
Copy link
Contributor Author

autumnull commented Jul 15, 2021

rust-analyzer works fine but i still have the ghost window issue unfortunately 😕

EDIT: I've checked that it is atom-ide-rust that is the cause, because i disabled all packages besides this one and the issue still occurs, but doesn't occur if i disable this package.

@aminya
Copy link
Contributor

aminya commented Jul 15, 2021

@autumnull Does #198 fix the issue for you?

@autumnull
Copy link
Contributor Author

Yes that works great, no more ghost window 🙂 thank you <3

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants