File tree Expand file tree Collapse file tree 5 files changed +9
-9
lines changed Expand file tree Collapse file tree 5 files changed +9
-9
lines changed Original file line number Diff line number Diff line change @@ -15,7 +15,7 @@ Generally,
15
15
- Fields should only be present when needed, saving space and parse time
16
16
- Also, we can always switch to always outputting the fields but its harder to stop outputting them
17
17
- ` #[serde(skip_serializing_if = "Default::default")] ` should be applied liberally
18
- - For output, prefer [ jsonlines] ( https://jsonlines.org/ ) as it allows streaming output and flexibility to mix content (e.g. adding diagnostics to output that didn't prevously have it
18
+ - For output, prefer [ jsonlines] ( https://jsonlines.org/ ) as it allows streaming output and flexibility to mix content (e.g. adding diagnostics to output that didn't previously have it
19
19
- ` #[serde(deny_unknown_fields)] ` should not be used to allow evolution of formats, including feature gating
20
20
21
21
## Schema Evolution Strategies
Original file line number Diff line number Diff line change @@ -42,18 +42,18 @@ When adding a table to a manifest,
42
42
- Should it be inheritable?
43
43
- Ensure the package table and the inheritable table under ` workspace ` align
44
44
- Care is needed to ensure a ` workspace = true ` field doesn't conflict with other entries
45
- - e.g. [ RFC 3389] had to explicitly exclude ever supporing a ` workspace ` linter
45
+ - e.g. [ RFC 3389] had to explicitly exclude ever supporting a ` workspace ` linter
46
46
47
47
When adding a field,
48
48
- Is it inheritable?
49
- - Consider whether sharing of the field would be driven by requirements or is a manifestion of the current implementation.
49
+ - Consider whether sharing of the field would be driven by requirements or is a manifestation of the current implementation.
50
50
For example, in most cases, dependency sources (e.g. ` version ` field) should be aligned across a workspace
51
51
However, frequently dependency ` features ` will vary across a workspace.
52
52
- When inheriting, can specify it in your package?
53
53
- How does specifying a field in both ` workspace ` and a package interact?
54
54
- e.g. dependency sources cannot be overridden
55
55
- e.g. dependency ` features ` get merged
56
- - e.g. depedency ` default-features ` has been hard to get right ([ #12162 ] [ cargo#12162 ] )
56
+ - e.g. dependency ` default-features ` has been hard to get right ([ #12162 ] [ cargo#12162 ] )
57
57
58
58
When working extending ` dependencies ` tables:
59
59
- How does this affect ` cargo add ` or ` cargo remove ` ?
Original file line number Diff line number Diff line change @@ -38,7 +38,7 @@ Roughly the steps are:
38
38
git commit
39
39
```
40
40
41
- 5 . Create an PR on rust-lang/rust.
41
+ 5 . Create a PR on rust-lang/rust.
42
42
43
43
Push your submodule changes to GitHub and make a PR.
44
44
Start the PR title with ` [EXPERIMENT] ` to make it clear what the PR is for and assign yourself or @ghost .
Original file line number Diff line number Diff line change 950
950
[ #14211 ] ( https://github.com/rust-lang/cargo/pull/14211 )
951
951
- Use ` std::fs::absolute ` instead of reimplementing it
952
952
[ #14075 ] ( https://github.com/rust-lang/cargo/pull/14075 )
953
- - Remove unecessary feature activations from cargo.
953
+ - Remove unnecessary feature activations from cargo.
954
954
[ #14122 ] ( https://github.com/rust-lang/cargo/pull/14122 )
955
955
[ #14160 ] ( https://github.com/rust-lang/cargo/pull/14160 )
956
956
- Revert #13630 as rustc ignores ` -C strip ` on MSVC.
3172
3172
3173
3173
### Nightly only
3174
3174
3175
- - Implemented a initial support of asymmetric token authentication for registries.
3175
+ - Implemented initial support of asymmetric token authentication for registries.
3176
3176
([ RFC 3231] ( https://github.com/rust-lang/rfcs/blob/master/text/3231-cargo-asymmetric-tokens.md ) )
3177
3177
([ docs] ( https://doc.rust-lang.org/nightly/cargo/reference/unstable.html#registry-auth ) )
3178
3178
[ #10771 ] ( https://github.com/rust-lang/cargo/pull/10771 )
3306
3306
[ #11227 ] ( https://github.com/rust-lang/cargo/pull/11227 )
3307
3307
- Added support for git dependencies having git submodules with relative paths.
3308
3308
[ #11106 ] ( https://github.com/rust-lang/cargo/pull/11106 )
3309
- - Cargo now sends requests with a ` Accept-Encoding ` header to registries.
3309
+ - Cargo now sends requests with an ` Accept-Encoding ` header to registries.
3310
3310
[ #11292 ] ( https://github.com/rust-lang/cargo/pull/11292 )
3311
3311
- Cargo now forwards non-UTF8 arguments to external subcommands.
3312
3312
[ #11118 ] ( https://github.com/rust-lang/cargo/pull/11118 )
Original file line number Diff line number Diff line change @@ -189,7 +189,7 @@ These incompatibilities usually manifest as a compile-time error, but
189
189
sometimes they will only appear as a runtime misbehavior. For example, let's
190
190
say there is a common library named ` foo ` that ends up appearing with both
191
191
version ` 1.0.0 ` and ` 2.0.0 ` in the resolve graph. If [ ` downcast_ref ` ] is used
192
- on a object created by a library using version ` 1.0.0 ` , and the code calling
192
+ on an object created by a library using version ` 1.0.0 ` , and the code calling
193
193
` downcast_ref ` is downcasting to a type from version ` 2.0.0 ` , the downcast
194
194
will fail at runtime.
195
195
You can’t perform that action at this time.
0 commit comments