Skip to content

cargo should clone iced and smithay one time and partial #13671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
soloturn opened this issue Mar 31, 2024 · 1 comment
Closed

cargo should clone iced and smithay one time and partial #13671

soloturn opened this issue Mar 31, 2024 · 1 comment
Labels
A-git Area: anything dealing with git C-bug Category: bug S-blocked-external Status: ❌ blocked on something out of the direct control of the Cargo project, e.g., upstream fix

Comments

@soloturn
Copy link
Contributor

soloturn commented Mar 31, 2024

Problem

rust based desktop cosmic desktop has modules. most modules depend on smithay and iced git repo. building cosmic modules clones such dependencies 20 times, and cannot be convinced to do a partial clone, despite stting CARGO_TARGET_DIR.

Steps

git clone [email protected]:pop-os/cosmic-epoch.git
cd cosmic-epoch
git submodule update --init --filter=tree:0
RUSTUP_TOOLCHAIN=stable CARGO_TARGET_DIR=/tmp/mytarget CARGO_REGISTRIES_CRATES_IO_PROTOCOL=sparse just sysext

Possible Solution(s)

somehow put the checked out repo into same location, and pass GITFLAGS "--filter=tree:0"

Notes

No response

Version

No response

@soloturn soloturn added C-bug Category: bug S-triage Status: This issue is waiting on initial triage. labels Mar 31, 2024
@weihanglo
Copy link
Member

The dependency tree contains the same dependencies on different revision, so multiple clones is unavoidable unless one commit object is already included in the git history of the other. Some experimental git features like shallow clones can be found in -Zgitoxide and -Zgit unstable flags. Sparse and partial clones supports are being tracked under #11165, so close in favor of them. Thanks for the report.

@weihanglo weihanglo closed this as not planned Won't fix, can't repro, duplicate, stale Mar 31, 2024
@weihanglo weihanglo added A-git Area: anything dealing with git S-blocked-external Status: ❌ blocked on something out of the direct control of the Cargo project, e.g., upstream fix and removed S-triage Status: This issue is waiting on initial triage. labels Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-git Area: anything dealing with git C-bug Category: bug S-blocked-external Status: ❌ blocked on something out of the direct control of the Cargo project, e.g., upstream fix
Projects
None yet
Development

No branches or pull requests

2 participants